Deluge
#1349 closed bug (Fixed)
deluge-gtk side panel drawn incorrectly when using specific GTK+ themes
| Reported by: | lexa2 | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | GTK UI | Version: | 1.3.1 |
| Keywords: | gui side panel | Cc: | bertrand.croq+deluge@… |
Description
deluge-gtk draw side panel as GtkTreeView? inside GtkScrolledWindow?.
To make items like "All", "Seeding", "Active" not indented too far to the left it sets GtkTreeView?->level-indentation to -35 which violates GTK+ requirements (as described at http://library.gnome.org/devel/gtk/stable/GtkTreeView.html#GtkTreeView--level-indentation) and makes side panel prone to the incorrect appearance when GtkTreeView?'s expander-size style is set to anything lower than default 12 (and generally speaking even with expander-size=12 sidebar looks like being drawn wrong with so-called "compact" themes like "Clearlooks Compact" or "Human Compact").
Graphical "glitch" is that treeview items got placed too far to the left making them crop with the right border of the treeeview (look at the attached screenshot).
Thus GUI results in being drawn wrong when using some perfectly legal gnome themes due to deluge not following GTK+ docs so I consider this to be a bug that require some modifications to the way deluge use to draw side panel.
Attachments (2)
Change History (11)
Changed 13 years ago by lexa2
comment:1 Changed 13 years ago by andar
If you can suggest a way on how we can get the current theme's indentation level, then that'd be appreciated. As far as I know, there is no real way to do so and thus we've been stuck using -35 to render the sidebar as we want it.
comment:2 Changed 13 years ago by johnnyg
- Milestone changed from Future to 1.4.0
comment:3 Changed 13 years ago by andar
- Milestone changed from 1.4.0 to 1.3.1
- Resolution set to fixed
- Status changed from new to closed
Fixed in 1.3-stable.
comment:4 Changed 13 years ago by bcroq
- Cc bertrand.croq+deluge@… added
- Resolution fixed deleted
- Status changed from closed to reopened
I still get the problem using deluge-1.3.1-1ubuntu1 on xubuntu natty, whatever the theme I try (I currently use the "Xfce" theme)
comment:5 Changed 13 years ago by Cas
- Component changed from other to gtkui
- Milestone changed from 1.3.1 to 1.3.2
- Priority changed from minor to trivial
- Type changed from defect to bug
- Version changed from 1.2.3 to 1.3.1
comment:6 Changed 12 years ago by Cas
- Milestone changed from 1.3.2 to 1.3.x
comment:7 Changed 12 years ago by Cas
Not sure how this can be fixed for XFCE theme but you could edit either of the following two values in filtertreeview.py to see what works best.
self.label_view.set_level_indentation = -35 GtkTreeView::expander-size = 15
For reference this is andar's workaround: 2a3eb0
comment:8 Changed 11 years ago by Cas
- Resolution set to fixed
- Status changed from reopened to closed
Testing with Xubuntu 12.04 showed no issues so closing.
Re-attaching with different name due to Trac not able to handle names with # character correctly.