Opened 13 years ago

Closed 13 years ago

#1506 closed patch (Fixed)

scheduler plugin does not restore speed on yellow->green transition

Reported by: wyrm Owned by: Calum
Priority: minor Milestone: 1.3.2
Component: Plugin Version: 1.3.1
Keywords: scheduler Cc:


Everything works as expected on a green->yellow transition, but max speed is NOT restored on a yellow->green transition.

Change History (5)

comment:1 by wyrm, 13 years ago

Im running deluge-daemon on my htpc server, and deluge-gtk on my laptop, the speed reported on the deluge-gtk status line is always the max_(download|upload)_speed from core.conf, the GUI doesn't change the status line on green->yellow transition, but it DOES limit the speed as expected.

I have the following plugins enabled: Scheduler, Stats and WebUi.

Some relevant stuff from my configuration:

wyrm@htpc:~/.config/deluge$ cat core.conf | grep -E "\"max_(upload|download)_speed\""
  "max_upload_speed": 20.0, 
  "max_download_speed": 80.0, 

wyrm@htpc:~/.config/deluge$ cat scheduler.conf | grep -E "\"low_(up|down)\""
  "low_up": 5.0, 
  "low_down": 20.0, 

All the other config values, such as "max_active_limit/low_active", "max_active_downloading/low_active_down" and "max_active_uploading/low_active_up" does work as expected, it changes .torrent state to "queued" on green->yellow transition and resumes the torrent properly on yellow->green transition. The issue only happens with the "speed" values.

comment:2 by wyrm, 13 years ago

Turns out that only max_upload_speed wasn't being correctly restored, seems to be just a copynpaste issue. patch attached.

diff -bruN scheduler.orig/ scheduler/
--- scheduler.orig/	2011-02-01 12:13:58.000000000 -0200
+++ scheduler/	2011-02-01 12:14:24.000000000 -0200
@@ -64,7 +64,7 @@
-    "max_download_speed",
+    "max_upload_speed",

comment:3 by Calum, 13 years ago

Milestone: Future1.3.2
Priority: majorminor
Type: defectpatch

comment:4 by Calum, 13 years ago

Owner: set to Calum
Status: newaccepted

comment:5 by Calum, 13 years ago

Resolution: fixed
Status: acceptedclosed

1.3-stable: 1731fd641b

Note: See TracTickets for help on using tickets.