Opened 14 years ago
Closed 14 years ago
#1506 closed patch (Fixed)
scheduler plugin does not restore speed on yellow->green transition
Reported by: | wyrm | Owned by: | Calum |
---|---|---|---|
Priority: | minor | Milestone: | 1.3.2 |
Component: | Plugin | Version: | 1.3.1 |
Keywords: | scheduler | Cc: |
Description
Everything works as expected on a green->yellow transition, but max speed is NOT restored on a yellow->green transition.
Change History (5)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
Turns out that only max_upload_speed wasn't being correctly restored, seems to be just a copynpaste issue. patch attached.
diff -bruN scheduler.orig/core.py scheduler/core.py --- scheduler.orig/core.py 2011-02-01 12:13:58.000000000 -0200 +++ scheduler/core.py 2011-02-01 12:14:24.000000000 -0200 @@ -64,7 +64,7 @@ CONTROLLED_SETTINGS = [ "max_download_speed", - "max_download_speed", + "max_upload_speed", "max_active_limit", "max_active_downloading", "max_active_seeding"
comment:3 by , 14 years ago
Milestone: | Future → 1.3.2 |
---|---|
Priority: | major → minor |
Type: | defect → patch |
comment:4 by , 14 years ago
Owner: | set to |
---|---|
Status: | new → accepted |
Note:
See TracTickets
for help on using tickets.
Im running deluge-daemon on my htpc server, and deluge-gtk on my laptop, the speed reported on the deluge-gtk status line is always the max_(download|upload)_speed from core.conf, the GUI doesn't change the status line on green->yellow transition, but it DOES limit the speed as expected.
I have the following plugins enabled: Scheduler, Stats and WebUi.
Some relevant stuff from my configuration:
All the other config values, such as "max_active_limit/low_active", "max_active_downloading/low_active_down" and "max_active_uploading/low_active_up" does work as expected, it changes .torrent state to "queued" on green->yellow transition and resumes the torrent properly on yellow->green transition. The issue only happens with the "speed" values.