Opened 11 years ago

Closed 11 years ago

#1581 closed patch (Fixed)

Provide a way to disable usage of the application indicator interface

Reported by: nick Owned by:
Priority: trivial Milestone: 1.3.2
Component: GTK UI Version: 1.3.0_dev
Keywords: Cc:

Description

I personally really dislike the way an application indicator behaves, so even if the library is available, I'd like to have the old systray icon.

I've attached a patch that provides a new option to disable usage of the application indicator. Seems to work quite nicely for me.

Attachments (2)

disable_appindicator.patch (9.3 KB) - added by nick 11 years ago.
Patch to add option for disabling the use of application indicator
enable_appindicator_patch.patch (8.9 KB) - added by nick 11 years ago.
Add 'enable application indicator' option to gtkui. Defaults to false.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by nick

Patch to add option for disabling the use of application indicator

comment:1 Changed 11 years ago by Cas

  • Milestone changed from Future to 1.3.2
  • Priority changed from major to trivial
  • Type changed from feature-request to patch

comment:2 Changed 11 years ago by andar

I think it would better to make this option "Enable Application Indicator" and keep its default as False. Having "positive" actions is a better design imo.

Any chance you could change the patch to reflect this?

comment:3 Changed 11 years ago by Cas

I also thought about this but would mean the icon was actually missing on Natty and could have a lot of users asking where its gone.

This will only affect people with appindicator installed.

comment:4 Changed 11 years ago by damoxc

Debian packages have the power to patch, so I'm sure they can flip the option by default...

I'm with andar on this, the default shouldn't cater for Ubuntu.

comment:5 Changed 11 years ago by andar

Yes, this was exactly my thoughts. Ubuntu can simply patch the default to True for their users. I don't like it on by default because it really lacks functionality compared to the system tray and not everyone that has app indicator installed actually wants to use it.

comment:6 Changed 11 years ago by nick

Sounds reasonable. I'll see about switching up the patch so it's a positive icon. Hopefully will have time soon.

Changed 11 years ago by nick

Add 'enable application indicator' option to gtkui. Defaults to false.

comment:7 Changed 11 years ago by nick

Okay, uploaded a patch with a positive option that defaults the option to false.

comment:8 Changed 11 years ago by andar

  • Resolution set to fixed
  • Status changed from new to closed

Committed. Thanks!

Note: See TracTickets for help on using tickets.