Opened 13 years ago

Closed 11 years ago

#1872 closed patch (Fixed)

Replace WMI processes enumeration with EnumProcesses

Reported by: ETZel Owned by:
Priority: minor Milestone: 1.3.6
Component: Core Version: 1.3.5
Keywords: win32 daemon startup Cc:

Description

Enumeration through WMI is inferior to ​EnumProcesses because

  • it's 100+ times slower
  • it loads several MB of unnecessary libraries
  • currently, it's the only pythoncom dependency in Deluge

Note: the most correct way to check if a process is running is to use OpenProcess + GetExitCodeProcess. But it requires a lot more code for little to no benefit.

Attachments (1)

0001-Replaced-WMI-process-enumeration-with-the-EnumProces.patch​ (1.4 KB) - added by ETZel 13 years ago.

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by ETZel

comment:1 Changed 13 years ago by Cas

  • Milestone changed from Future to 1.4.0

comment:2 Changed 11 years ago by Cas

  • Milestone changed from 1.4.0 to 1.3.6
  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from git master to 1.3.5

Thanks ETZel. I've added it to 1.3-stable: ​8a72187998

Note: See TracTickets for help on using tickets.