Opened 10 years ago

Closed 8 years ago

Last modified 4 years ago

#1885 closed bug (Fixed)

Wrong tracker icon for trackers with no favicon in Tracker column

Reported by: DaVince Owned by: johnnyg
Priority: trivial Milestone: 2.x
Component: Unknown Version: 1.3.2
Keywords: tracker, icon Cc:

Description

When there are servers with no favicon inbetween torrents with servers that do have a favicon, the iconless torrents still tend to have an icon, but they take the icon of a different torrent in the list. To demonstrate best, I have attached a screenshot. Look at the favicons for the servers: they are all the same, even though the nyaatorrents.org ones should have either no icon or a different icon altogether.

More Info: http://forum.deluge-torrent.org/viewtopic.php?f=8&t=36935

Attachments (1)

10fc58779baa0e5baa94f3a697a9ffa355763f61.patch (5.0 KB) - added by Cas 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by johnnyg

  • Component changed from gtkui to other
  • Owner changed from Cas to johnnyg
  • Status changed from new to accepted

This is actually due to the tracker's webmaster not knowing how to use http status codes:

  • redirection of main page is done by a meta tag with http-equiv="refresh"
  • 404 page is done by redirecting to a page which returns 200

I'll commit a fix shortly.

comment:2 Changed 10 years ago by Cas

  • Milestone changed from 1.3.3 to 1.3.x

comment:3 Changed 8 years ago by Cas

  • Milestone changed from 1.3.x to 1.4.0

If the website is not following specs properly then I don't think we have to fix our code however the issue with displaying the wrong icon is a bug.

It is due using deferred callback when setting cell icon data and there is a proposed fix (also attached as patch).

comment:4 Changed 8 years ago by johnnyg

I think the committing a fix shortly was referring to the wrong icon (not the server being incorrect) however it was so long ago I can't recall if that's what I was referring to (or if I actually did it).

I don't really see the point of that fix as it just seems to add an unnecessary synchronous method to tracker_icons and introduces a global in the UI code.

I'll have a look at it tomorrow to see what's going on.

comment:5 Changed 8 years ago by bro

johnnyg, the problem with the wrong icons being set is that the code that sets the data for the cellrenderer must be synchronous. This patch fixes this, and sets an empty icon instead of leaving the data field with the previous value, causing the wrong icon being shown.

comment:6 Changed 8 years ago by Cas

Fixed in develop: [8ecc0e11a79d92]

comment:7 Changed 8 years ago by Cas

  • Resolution set to Fixed
  • Status changed from accepted to closed

comment:8 Changed 4 years ago by Cas

  • Milestone changed from 2.0.x to 2.x

Milestone renamed

Note: See TracTickets for help on using tickets.