Opened 13 years ago

Closed 10 years ago

Last modified 6 years ago

#1908 closed patch (Fixed)

Minor improvement to bind the webui to an interface

Reported by: friedrichg2 Owned by: Damien Churchill
Priority: minor Milestone: 2.0.0
Component: Web UI Version: master
Keywords: Cc:

Description

Tested with:

  • python 2.7.1 in linux with master branch
  • python 2.5 in Windows Xp in stable version 1.3.3

Attachments (3)

0001-modified-deluge-ui-web-server.py.patch (2.0 KB ) - added by friedrichg2 13 years ago.
patch for server.py
webui.listenaddress.patch (3.3 KB ) - added by friedrichg2 13 years ago.
webui.patch (3.2 KB ) - added by friedrichg2 13 years ago.
fixed huge mistake…

Download all attachments as: .zip

Change History (10)

by friedrichg2, 13 years ago

patch for server.py

comment:1 by andar, 13 years ago

This should also include an option for the command line.

comment:2 by Calum, 13 years ago

Milestone: Future1.4.0

comment:3 by Calum, 13 years ago

I think using the term interface is just as confusing as it is currently in deluged. Since the parameter to supply is an ip address and not an actual ethernet interface.

My suggestion would be for listen-address so in code use listen_address and for the command line option:

-a, --listen-address

This would free up interface for use in the future with the actual interface as a parameter.

by friedrichg2, 13 years ago

Attachment: webui.listenaddress.patch added

comment:4 by friedrichg2, 13 years ago

I chose interface because that is they way it is called in the twisted API listenTCP --> http://goo.gl/PWw2B and listenSSL --> http://goo.gl/PWw2B

I also think there is no way to bind an ethernet/HW address to a socket using twisted/python or any language I know.

But, I agree that the term can be misleading. (Maybe file a bug in Twisted?).

So here is the patch rewritten using listen-address. Also tested again with config file and command line switch in Linux.

by friedrichg2, 13 years ago

Attachment: webui.patch added

fixed huge mistake...

comment:5 by Calum, 10 years ago

Resolution: Fixed
Status: newclosed

Added to develop: [49d4bb496]

comment:6 by Calum, 9 years ago

Milestone: 2.0.x2.0

comment:7 by Calum, 6 years ago

Milestone: 2.02.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.