Mutable default argument in deluge.ui.client.DaemonSSLProxy.__init__

[Simon]

Hi,

When looking at the source code I saw that DaemonSSLProxy.init have a mutable default parameter value: ​http://git.deluge-torrent.org/deluge/tree/deluge/ui/client.py#n269

This may be the source of bugs as explained here:

​http://effbot.org/zone/default-values.htm#valid-uses-for-mutable-defaults

It may be intentional, but I am not sure as I am not familiar with the code. If it is intentional, a comment should be added to say so. Otherwise, the method should be changed to look like this:

    def __init__(self, event_handlers=None):
        if event_handlers is None:
            event_handlers = {}

[Calum]

Fix committed to 1.3-stable: ​3a0b6f8

[Calum]

Fix committed to master: ​2a3d8ae

[Calum]

Milestone renamed