#1972 closed patch (Fixed)
Useless ui.UI class
| Reported by: | jumentous | Owned by: | Calum |
|---|---|---|---|
| Priority: | minor | Milestone: | 2.0.0 |
| Component: | Core | Version: | master |
| Keywords: | Cc: | jamielennox@gmail.com, Bro |
Description
Whilst it would appear that the ui.py:UI class used to be intended for something it is only used in 2 places:
- from start_ui where it is called to choose which UI to launch. However at no point here does it use self so in essence this could/should just be a function.
- as a base class for deluge/ui/web/web.py:Web, however the init of this class does not chain to the parent class or do anything similar.
I can only imagine that this cross over came from old, removed code and is no longer needed.
This code can simply be merged back into start_ui, if for no other reason that it's less confusing for people reading the code and distinguishing the difference between the _UI and UI classes.
Attachments (1)
Change History (6)
comment:1 by , 14 years ago
| Cc: | added |
|---|
by , 14 years ago
| Attachment: | 0001-Removed-ui.UI-class.patch added |
|---|
comment:2 by , 11 years ago
| Milestone: | 1.4.0 → 2.0.0 |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
comment:4 by , 9 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
Merged in develop: [b86a021042723e]
Note:
See TracTickets
for help on using tickets.
Note: needs the patch in #1971 to apply cleanly.