Opened 9 years ago

Closed 5 years ago

Last modified 3 years ago

#1972 closed patch (Fixed)

Useless ui.UI class

Reported by: jumentous Owned by: Cas
Priority: minor Milestone: 2.0.0
Component: Core Version: master
Keywords: Cc: jamielennox@…, bro

Description

Whilst it would appear that the ui.py:UI class used to be intended for something it is only used in 2 places:

  1. from start_ui where it is called to choose which UI to launch. However at no point here does it use self so in essence this could/should just be a function.
  1. as a base class for deluge/ui/web/web.py:Web, however the init of this class does not chain to the parent class or do anything similar.

I can only imagine that this cross over came from old, removed code and is no longer needed.

This code can simply be merged back into start_ui, if for no other reason that it's less confusing for people reading the code and distinguishing the difference between the _UI and UI classes.

Attachments (1)

0001-Removed-ui.UI-class.patch (6.0 KB) - added by jumentous 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by jumentous

  • Cc jamielennox@… added

Note: needs the patch in #1971 to apply cleanly.

Changed 9 years ago by jumentous

comment:2 Changed 7 years ago by Cas

  • Milestone changed from 1.4.0 to 2.0.0
  • Owner set to Cas
  • Status changed from new to assigned

comment:3 Changed 5 years ago by bro

  • Cc bro added

Add bro to cc

comment:4 Changed 5 years ago by Cas

  • Resolution set to Fixed
  • Status changed from assigned to closed

Merged in develop: [b86a021042723e]

comment:5 Changed 3 years ago by Cas

  • Milestone changed from 2.0 to 2.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.