Opened 10 years ago

Closed 5 years ago

Last modified 3 years ago

#1974 closed patch (Fixed)

Core shouldn't have to know about the clients in advance

Reported by: jumentous Owned by:
Priority: minor Milestone: 2.0.0
Component: Unknown Version: master
Keywords: Cc: jamielennox@…, bro

Description

So, #1971, #1972, #1973 are bugs that were discovered in the trying to fix this point.

I am looking at adding a new UI to deluge, and in the process noticed that the core currently matches the chosen UI and launches the appropriate client. This makes it impossible to add a client developed out of the deluge tree.

This patch modifies setup to export the UI classes as entry points and load the entry point for the class. Details for this method can be found here: http://aroberge.blogspot.com/2008/12/plugins-part-6-setuptools-based.html and http://peak.telecommunity.com/DevCenter/PkgResources#locating-plugins

Note that it doesn't actually do a find_plugins yet, it's just moving towards it.

Now i realize that there is already a plugin format for deluge however i thought this more appropriate for something that will be relatively static and can be deployed by rpm/deb.

Obviously, comments/revisions are encouraged.

Attachments (1)

0001-Decouple-GUI-selection-from-core.patch (17.6 KB) - added by jumentous 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by jumentous

comment:1 Changed 10 years ago by jumentous

  • Cc jamielennox@… added

I've put the branch on github for the patches #1971 #1972 #1973 and this under detach-ui

https://github.com/jamielennox/deluge/tree/detach-ui

comment:2 Changed 10 years ago by Cas

  • Milestone changed from Future to 1.4.0
  • Type changed from bug to patch
  • Version changed from other (please specify) to git master

comment:3 Changed 6 years ago by bro

  • Cc bro added

Add bro to cc

comment:4 Changed 5 years ago by Cas

  • Milestone changed from 2.0.x to 2.0
  • Resolution set to Fixed
  • Status changed from new to closed

Merged in develop: [6343f32d70408ba6ab]

comment:5 Changed 3 years ago by Cas

  • Milestone changed from 2.0 to 2.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.