Clean exit verification with state backup

[Chotaz]

I usually have a large volume of torrents attached to deluge(currently 4TB in files, indivudual torrent size goes up to 100GB) and having this large storage system, I like to periodically check my disks for errors. Yet this has been taking some time off my seeding because with this large amount of torrents, every time i try closing the deamon(pkill deluge), it doesn't quit cleanly. This makes deluge have to check 4TB of files every single time i kill or stop deluged(usually takes a full day to do so with my drives).

My idea was to add a flag on the deamon close function that gets set if it's done cleanly and a way to cache torrent stats. The flag would be verified everytime the daemon is ran again and if it wasnt found, the latest cached stats would load after all the torrent checking is done.

[Calum]

There was a recent fix applied that may be relevant here: ​0676aaf91

[Calum]

We are looking to backup the state file and restore if a non-clean shutdown was detected which I think will cover what you are asking for.

[Calum]

Actually this is the discussed pseudocode:

On startup:
 
os.path.exists("state_file_test"):
    copy("torrents.state.prev", permanent dir/name)
    copy("torrents.state", permanent dir/name)
    Warn user?
 
cp torrents.state to torrents.state.prev
 
load_state...
 
 
on shutdown:
   save state
   delete "state_file_test"

[Calum]

I have committed code ​2c4ef9dbb30 that achieves the above pseudocode but still require some form of user notification.

[Bro]

Add bro to cc

[Calum]

Updated to use tarfile: [45e0d1093]

It is possible that might need to add code to delete old archives but since shutting down in more robust this should be less of an issue.

[Calum]

Milestone renamed