Issue with prefs pages when enabling/disabling plugins in webui

[Calum]

Noticed that pages are not adding or removing for some reason when enabling or disabling a plugin and can even sometimes end up with multiple pages. Refreshing browser solves the issue though.

[Calum]

The problem here is that the event manager stops not long after starting due to null events so any PluginEnabledEvents are just not processed unless browser refreshed. Also noticed that the errorCount is never reset if there are successful events.

From testing so far this seems the likely solution:

deluge/ui/web/js/deluge-all/EventsManager.js

@@ -91 +91 @@
        },
 
        onGetEventsSuccess: function(events) {
-               if (!events) return;
+               this.errorCount = 0;
+               if (events){
                        Ext.each(events, function(event) {
                                var name = event[0], args = event[1];
                                args.splice(0, 0, name);
                                this.fireEvent.apply(this, args);
                        }, this);
+               }
                if (this.running) this.getEvents();
        },

[Chase]

I have some more work on this in ​this branch. There are some errors after plugins (at least label) are disabled, unsure if it's related.

[Chase]

Fixed in 1.3-stable: ​782b39c90db, ​e865180e832