wrong share ratio counting

[hunterk]

Share ratio is being counted incorrectly. For example: I've downloaded 1,2GB and uploaded 2,9 so how come my ratio is 1,03 ? I think that at present ratio is counted by dividing "upload" to "torrent size" instead of "upload" to "download".

[hunterk]

Client: 1.3.4

libtorrent: 0.15.11.0

[Cas]

What is the size of the torrent and had you already downloaded some of the torrent before adding it to Deluge?

The ​code for ratio is currently all_time_upload/total_done so it may require tweaking.

[hunterk]

torrent size = 2.8GB, yes I've downloaded half of that torrent in other program, day after that I decided to continue downloading and seeding it in Deluge.

[Raziel.Azrael]

Replying to hunterk:

torrent size = 2.8GB, yes I've downloaded half of that torrent in other program, day after that I decided to continue downloading and seeding it in Deluge.

You mean when you started deluge you've already downloaded 1.4 GB in another client?

[Raziel.Azrael]

Replying to Raziel.Azrael:

Replying to hunterk:

torrent size = 2.8GB, yes I've downloaded half of that torrent in other program, day after that I decided to continue downloading and seeding it in Deluge.

You mean when you started deluge you've already downloaded 1.4 GB in another client?

It seems that when you started Deluge after already downloading some of your torrent with another client, Deluge considered that it had downloaded it all ( it is possible that Deluge doesn't store what it actually downloaded but checks it from how complete the files are? ) The ratio seems to be calculated correctly, if there is a problem is in how Deluge calculates all downloaded data, especially after Deluge is closed and reopened.

[gazpachoking]

So, this is only a problem when you have partially downloaded the torrent in another client? In that case, I don't think there is any way for deluge to do better. If you are using the ratio to decide when to stop seeding, and we did <total up by deluge>/<total down by deluge> you might violate your tracker's policy if you had not uploaded anything in your previous client. I think the current conservative behavior is better than that. i.e. better to overshare than undershare.