Opened 9 years ago

Closed 8 years ago

#2076 closed plugin-request (Fixed)

[Extractor] Support for extracting rar on Windows

Reported by: kristixs Owned by:
Priority: major Milestone: 1.3.6
Component: Plugin Version: 1.3.4
Keywords: Cc:

Description (last modified by Cas)

i am currently using windows server 2008 r2 with the desktop experience (basically its windows 7). the Extractor plugin loads in windows, the check boxes are available in the GUI but the actual plugin does not seem to work. I also took an almost completed torrent and forced a recheck, then let the torrent finish to see if it would work that way and it did not.

after searching the forums it came to my attention that other windows users had complained the extractor was not working and replies stated that though the plugin will install on windows, it only currently works in linux. could you please fix this? an alternative would there be an Execute script posted in the plugins section or included with deluge that would use Winrar or Universal Extractor to extract completed torrents automatically, but a plugin is far easier to use.

Change History (12)

comment:1 Changed 9 years ago by kristixs

  • Priority changed from minor to major

comment:2 Changed 9 years ago by Cas

  • Description modified (diff)
  • Summary changed from extractor does not seem to work on windows to [Extractor] Support for extracting on Windows

comment:3 Changed 9 years ago by Cas

  • Summary changed from [Extractor] Support for extracting on Windows to [Extractor] Support for extracting rar on Windows

Using thepy-unrar2 module could make this simpler to fix.

Alternatively 7zip supports extracting rar and has a command line program which could be used.

comment:4 Changed 9 years ago by Cas

I have some relatively untested code that should work:

https://github.com/cas--/Deluge/compare/1.3-stable...Feature;Plugin;Extractor;SupportWindows

It requires 7-zip to be installed in default location or added to windows PATH.

comment:5 Changed 8 years ago by Cas

  • Milestone changed from 1.3.x to 1.3.6

comment:6 follow-ups: Changed 8 years ago by jkaberg

Tried your code today, compiled the egg and updated the plugin in Deluge. Didnt fly im affraid

Debug log: http://pastebin.com/af7JN3Lr Directory list: http://pastebin.com/z0vjEMLT

comment:7 in reply to: ↑ 6 Changed 8 years ago by jkaberg

Replying to jkaberg:

Tried your code today, compiled the egg and updated the plugin in Deluge. Didnt fly im affraid

Debug log: http://pastebin.com/af7JN3Lr Directory list: http://pastebin.com/z0vjEMLT

PS: Nothing gets extracted, it just creates an empty dir in output location

comment:8 in reply to: ↑ 6 Changed 8 years ago by jkaberg

Replying to jkaberg:

Tried your code today, compiled the egg and updated the plugin in Deluge. Didnt fly im affraid

Debug log: http://pastebin.com/af7JN3Lr Directory list: http://pastebin.com/z0vjEMLT

PS2: Why cant I edit? :( Anyhow, 7zip installed in default location (C:\Program Files\7-Zip)

comment:9 Changed 8 years ago by jkaberg

So if I read your code correctly your passing 7z x -y C:\path\to\input.rar C:\path\to\output\dir

But your missing -o, this will work (I tested with manual input) 7z x -y C:\path\to\input.rar -oC:\path\to\output\dir

comment:10 Changed 8 years ago by Cas

The logs show that it is not using the new Extractor code, you will actually need to delete the old version in C:\Program Files\Deluge\deluge-1.3.5-py2.6.egg\deluge\plugins.

comment:11 Changed 8 years ago by jkaberg

Thats odd, thought I did that but rechecked, recompiled and tested again, and this time it worked :) Nice work! Would it be possible to add an label option to the extractor, so if the label plugin is enabled it would turn out as /extract/to/<label>/<torrent name>/<files>.<ext>. Would really help with automation

comment:12 Changed 8 years ago by Cas

  • Resolution set to fixed
  • Status changed from new to closed

Fixed 1.3-stable: e2e37a83d

Note: See TracTickets for help on using tickets.