Opened 12 years ago

Closed 12 years ago

#2142 closed bug (Fixed)

1.3.5 uses try/except incorrectly in two places

Reported by: stromberg Owned by:
Priority: minor Milestone: 1.3.6
Component: Unknown Version: 1.3.5
Keywords: Cc: stromberg@gaikai.com

Description

I believe 1.3.5 uses try/except in a way that fails to catch one of the two listed exceptions, instead overwriting the second exception listed with detail related to the first. I believe this source of bugs is why try/except's syntax was changed slightly in Python 3.x.

The syntax is fine, but I doubt it's doing what's intended.

I've attached a diff that fixes the two bad try/except's by simply adding parentheses to form a tuple of exceptions.

Attachments (1)

excepts.patch (915 bytes ) - added by stromberg 12 years ago.

Download all attachments as: .zip

Change History (2)

by stromberg, 12 years ago

Attachment: excepts.patch added

comment:1 by Calum, 12 years ago

Resolution: fixed
Status: newclosed

Fixed 42118932

Note: See TracTickets for help on using tickets.