Unable to add torrent via URL

[underscor]

Hi guys! I get the following when attempting to add a torrent via URL. Any ideas?

deluge-console 'add -p "/1/downloads/9c8534b29cce486a571aa76f8225c35ee2e29d6d_wcd_ketsui-extra--dodon_manabu-namiki-_flac_lossless_1644875" "http://bt-download04/torrents.php?action=download&id=1644875&authkey=c28aba95c183165ef8ed2e8ae6a3bbbd&torrent_pass=4np8z7qkzb6dbv8pzdbqoqznvm7avir1"'
/1/"http:/bt-download04/torrents.php?action=download&id=1644875&authkey=c28aba95c183165ef8ed2e8ae6a3bbbd&torrent_pass=4np8z7qkzb6dbv8pzdbqoqznvm7avir1" doesn't exist!

[Damien Churchill]

Can you try without the double quotes? I think that my be the issue, when I looked they were still attached to the arguments. Obviously not correct but may allow you to continue with your testing :)

[underscor]

Hah, that fixed it! Interesting... I assume that's not the intended behaviour, right?

[Damien Churchill]

I'd imagine not, should be an easy fix though, gimmie a few minutes

[Damien Churchill]

Actually I'd like to talk to the console ui author before making any changes to see if there's any reason that they're doing it the way they are instead of just using the shlex module. I'll update this ticket when the problem is resolved!

[underscor]

Awesome, thanks!

[Damien Churchill]

Hi,

Would you mind testing out the following patch and seeing if it works for you?

deluge/ui/console/main.py

@@ -41 +41 @@
 import re
 import locale
 
+try:
+    import shlex
+except ImportError:
+    shlex = None
+
 from twisted.internet import defer, reactor
 
 import deluge.component as component
@@ -266 +271 @@
     def split(self, text):
         if deluge.common.windows_check():
             text = text.replace('\\', '\\\\')
-        result = re.split(r"(?<!\\) ", text)
+        if shlex:
+            result = shlex.split(text)
+        else:
+            result = re.split(r"(?<!\\) ", text)
         for i, s in enumerate(result):
             result[i] = s.replace(r'\ ', ' ')
         result = filter(lambda s: s != '', result)
@@ -475 +483 @@
                 component.get("LegacyUI").add_line(s, False)
                 self.events.append(s)
         else:
-            print colors.strip_colors(s.encode(self.encoding))
- No newline at end of file
+            print colors.strip_colors(s.encode(self.encoding))

[underscor]

Sorry, I've been sick. I will recompile with the patch tomorrow and let you know. Thanks!

[underscor]

Totally dropped the ball on this.

The patch fixes the problem for me. Thanks <3 :)

[Calum]

Fix in master: ​b67bae31

[Calum]

Milestone renamed