Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2202 closed patch (Fixed)

gtkui stable sort torrent view

Reported by: gazpachoking Owned by:
Priority: minor Milestone: 1.3.6
Component: GTK UI Version: 1.3.5
Keywords: sort Cc:

Description

Gtk TreeModelSort? sorts unstably, causing torrents to jump around when sorted by a column without unique values for all rows. Stable sort fixes this, as well as makes sorting by multiple columns in a row retain last sort when primary sort column is equal. Included in my branch here against 1.3-stable. (diff)

My only concern with this patch is that it uses torrent hash as unique row identifier, which is hard coded. Maybe unique column should be passed into ListView upon init.

Change History (3)

comment:1 Changed 9 years ago by gazpachoking

Ok, updated that branch to not use hard coded columns to grab unique id for rows. Also merged in bro's speedup branch.

comment:2 Changed 9 years ago by Cas

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from other (please specify) to 1.3.5

Fixed in 1.3-stable: 3c85cc4b03

comment:3 Changed 9 years ago by gazpachoking

This was backed out of 1.3-stable, however a replacement patch which still eliminates jitter was introduced. b7ca968fa.

The full stable sorting behavior was added to master. 1daae0135d

Note: See TracTickets for help on using tickets.