Opened 9 years ago

Closed 9 years ago

#2208 closed bug (Fixed)

Open Folder not working after Complete download moved under Windows

Reported by: Albertina Owned by:
Priority: minor Milestone: 1.3.6
Component: Windows OS Version: 1.3.5
Keywords: windows open folder completed Cc:

Description

Deluge: 1.3.5

Operating System: Windows 7 64 bits with Service Pack 1

Steps involved to reproduce the bug:

Select a folder for Incomplete downloads
Select a folder for Completed downloads
Right click an incomplete download and select Open Folder (it will open)
Right click the same download after it's completed and select Open Folder (it won't open)

Change History (4)

comment:1 Changed 9 years ago by Albertina

  • Version changed from other (please specify) to 1.3.5

comment:2 Changed 9 years ago by Cas

Just looked into this and it's an issue with non-ascii folder names, the fix should look something like the following but probably should be covered with a try..except for the decode.

  • deluge/common.py

    diff --git a/deluge/common.py b/deluge/common.py
    index 29c37e8..cfab4f8 100644
    a b def open_file(path): 
    240240 
    241241    """ 
    242242    if windows_check(): 
    243         os.startfile("%s" % path) 
     243        os.startfile(path.decode("utf8")) 
    244244    elif osx_check(): 
    245245        subprocess.Popen(["open", "%s" % path]) 
    246246    else: 

comment:3 Changed 9 years ago by Cas

  • Milestone changed from Future to 1.3.6

comment:4 Changed 9 years ago by Cas

  • Resolution set to fixed
  • Status changed from new to closed

Fixed 1.3-stable: 901f5a84bf0

Note: See TracTickets for help on using tickets.