Addtorrentdialog KeyError: download_location exception with new torrent file

[bvasiliev]

Cold starting Deluge in the daemon configuration through the gkt interface with the a new torrent file causes an error when adding a file from the queue.

How to reproduce:

1. Enable the daemon configuration (classic mode disable);
   
2. Verify that the deluged is not running;
   
3. Run the deluge-gtk with a new torrent file:
   

→ deluge-gtk ./t.torrent                         
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/addtorrentdialog.py", line 291, in _on_torrent_changed
    self.update_torrent_options(model.get_value(row, 0))
  File "/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/addtorrentdialog.py", line 361, in update_torrent_options
    self.set_default_options()
  File "/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/addtorrentdialog.py", line 458, in set_default_options
    self.core_config["download_location"])
KeyError: 'download_location'
[ERROR   ] 23:21:48 component:118 [Failure instance: Traceback: <type 'exceptions.KeyError'>: 'download_location'
/usr/lib/python2.7/dist-packages/twisted/internet/defer.py:290:addCallbacks
/usr/lib/python2.7/dist-packages/twisted/internet/defer.py:551:_runCallbacks
/usr/lib/python2.7/dist-packages/deluge/component.py:285:on_depends_started
/usr/lib/python2.7/dist-packages/deluge/component.py:124:_component_start
--- <exception caught here> ---
/usr/lib/python2.7/dist-packages/twisted/internet/defer.py:134:maybeDeferred
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/queuedtorrents.py:90:start
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/queuedtorrents.py:178:on_button_add_clicked
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/queuedtorrents.py:176:add_torrent
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/ipcinterface.py:227:process_args
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/addtorrentdialog.py:230:add_from_files
/usr/lib/python2.7/dist-packages/deluge/ui/gtkui/addtorrentdialog.py:458:set_default_options

[Calum]

I cannot replicate and the fact that it is opening the addtorrentdialog suggests that it is connected to the daemon. If you can test with a clean config please.

Also make sure that deluge-gtk is restarted when enabling/disabling classic mode, this will be fixed in next release so cannot be done accidentally.

[Calum]

This is clearly an ongoing bug as it has been reported on ​Ubuntu and ​Fedora but there appears to be no way for me to replicate it.

[Calum]

Fixed in 1.3-stable: ​686fb3184

Although doesn't explain why the default value for download_location does not exist, this fix will prevent the KeyError occurring and download_location will be simply set to None.

[Calum]

Reverted that non-fix, see #2496