Renaming folders do not move data to new folders

[miskoala]

I use git 1.3-stable, libtorrent-rasterbar 0.16.7 on Archlinux

I add new torrent in gtkui with folder name:
VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC

and download 0,5% of torrent content for example

then i change folder name to:
VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc

start downloading and new folder is created fine, but data from old folder are not moving to new folder
download in new folder starts from 0% (after torrent recheck)
already downloaded parts of files stays in old folder

[Calum]

I can confirm this is an issue and it seems that libtorrent 0.16 is no longer renaming the top level (base name) folder so only new data is written to the new folder name thus loss of previous downloaded data.

I am not sure there if this can be actually be fixed in Deluge.

[arvid]

There are no error messages? Like a storage_moved_failed_alert? Or does the operation appear to succeed?

[miskoala]

no error messages in log

[DEBUG   ] 08:57:08 torrentview:538 on_button_press_event
[DEBUG   ] 08:57:08 torrentview:559 on_selection_changed
[DEBUG   ] 08:57:09 files_tab:334 Getting file list from core..
[DEBUG   ] 08:57:10 files_tab:510 on_button_press_event
[DEBUG   ] 08:57:11 files_tab:510 on_button_press_event
[DEBUG   ] 08:57:14 files_tab:595 new_text: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/
[DEBUG   ] 08:57:14 torrent:951 attempting to rename folder: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC/ to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 0 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/01-Electronic_Dreamplanet_-_Virtual_Link.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 1 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/06-Zabra_-_Waterworld.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 2 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/04-Little_Blue_Men_-_Megamorphosis.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 3 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/03-Human_Blue_-_Epsilon.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 4 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/02-Psychlopedia_-_Clockwork_Orange.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 5 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/05-Subcouds_-_Plasticine_Hellyflowers.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 6 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/07-Weirdo_Beardo_-_Rastagoggles.flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 7 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/08-The_Mato_Project_-_I'm_Not_Coming_Back_(Boingy_Thing_Mix).flac
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 8 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-(Back)-FLAC.jpg
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 9 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-(Front)-FLAC.jpg
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 10 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.nfo
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 11 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/audiochecker.log
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 12 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.md5
[DEBUG   ] 08:57:14 alertmanager:123 file_renamed_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC: file 13 renamed to VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.m3u
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 0 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/01-Electronic_Dreamplanet_-_Virtual_Link.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 1 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/06-Zabra_-_Waterworld.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 2 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/04-Little_Blue_Men_-_Megamorphosis.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 3 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/03-Human_Blue_-_Epsilon.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 4 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/02-Psychlopedia_-_Clockwork_Orange.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 5 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/05-Subcouds_-_Plasticine_Hellyflowers.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 6 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/07-Weirdo_Beardo_-_Rastagoggles.flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 7 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/08-The_Mato_Project_-_I'm_Not_Coming_Back_(Boingy_Thing_Mix).flac
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 8 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-(Back)-FLAC.jpg
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 9 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-(Front)-FLAC.jpg
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 10 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.nfo
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 11 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/audiochecker.log
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 12 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.md5
[DEBUG   ] 08:57:14 torrentmanager:1077 on_alert_file_renamed
[DEBUG   ] 08:57:14 torrentmanager:1078 index: 13 name: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/00-VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC.m3u
[DEBUG   ] 08:57:14 rpcserver:466 intevents: {}
[DEBUG   ] 08:57:14 files_tab:771 on_torrent_folder_renamed_signal
[DEBUG   ] 08:57:14 files_tab:772 old_folder: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC/ new_folder: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/
[DEBUG   ] 08:57:14 files_tab:732 get_iter_at_path: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC/
[DEBUG   ] 08:57:14 files_tab:732 get_iter_at_path: VA_-_Musica_Psychedelica_Scandinavica-1998-FLACccccccccccccccc/
[DEBUG   ] 08:57:14 alertmanager:123 save_resume_data_alert: VA_-_Musica_Psychedelica_Scandinavica-1998-FLAC resume data generated
[DEBUG   ] 08:57:14 torrentmanager:1048 on_alert_save_resume_data
[DEBUG   ] 08:57:14 torrentmanager:736 Opening torrents fastresume file for load.

[arvid]

looking at the code, if a file is renamed to a path whose parent directory doesn't exist it would probably fail. I'm not sure why it would fail silently though. I'm putting in a fix for 0.16.8

[miskoala]

thanks I compiled from svn and renaming works fine now

[Calum]

Fixed in lt 0.16.8.