#2277 closed bug (Fixed)
get_torrent_status ignores plugins - Bug in commit 8c106ce8c4c0794ddd63e8e8f98b097221a56a52
Reported by: | Peter B. | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | 2.x |
Component: | Core | Version: | master |
Keywords: | Cc: | chase.sterling@gmail.com |
Description
Merge remote-tracking branch 'bro/master-daemon-optimize-speed' Commited: 2013-02-10 22:30:25 (GMT) Commit: 8c106ce8c4c0794ddd63e8e8f98b097221a56a52
deluge/core/filtermanager.py:192-195 the following two lines were removed
status_func = self.core.get_torrent_status #premature optimization.. status = status_func(torrent_id, filter_dict.keys()) #status={key:value}
and replaced with
status = self.torrents[torrent_id].get_status(filter_dict.keys()) #status={key:value}
The problem, from what I can gather, is that the torrent object, from self.torrents, does not have a list of plugin status keys. The previous code called core.get_torrent_status which included logic to append status keys provided by the plugin manager, the new code lacks this.
To test this request a filter on a status that is included via a plugin, such as 'label'. I reverted it back on my machine, but I am uncertain if this is the correct fix or if there would be something better that should be implemented.
Change History (5)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
comment:3 by , 12 years ago
Milestone: | Future → 1.4.0 |
---|
Link to the commit. http://git.deluge-torrent.org/deluge/commit/?id=8c106ce8c4c0794ddd63e8e8f98b097221a56a52