Deluge creates parent directories for output

[B-Con]

Problem

Deluge creates the necessary parent directories of it. However, it does not own the parent directory of the torrent output and thus should not manage it. Creating it is being overly helpful and the problems with auto-creating it include:

a) The parent directory may intentionally be missing

b) Deluge may create the directory with the wrong permissions

Steps to reproduce

1) Download torrent

2) Exit Deluge

3) Move said torrent and delete torrent's parent directory

4) Open Deluge

5) Deluge will create the parent directory and re-download the the torrent

Example

I had all torrents saved in a path like /storage/data/torrents/. (Eg: /storage/data/torrents/TORRENT_NAME.) /storage/data was a mountpoint for another filesystem. I quit Deluge, unmounted /storage/data, and rebooted. Deluge was set to auto-start on boot and it created /storage/data/torrents and then started to re-download everything. This both filled up the filesystem for /storage and caused undesired leeching.

Desired behavior

If the parent directory for a torrent is missing Deluge should not create it and instead fail to proceed.

[Calum]

Duplicate #1032

[B-Con]

I disagree that this is a duplicate of #1032. The solution to #1032 requests that torrents be *tracked* in some way, so that if a torrent that was completed changes to not being started it raises a flag and prompts the user. The solution to that problem would have prevented the specific problem encountered in this ticket's description, but that's coincidence, as it addresses a different underlying problem.

With this bug I simply don't think the parent directory created at all, even in circumstances other than the example.

[Calum]

The empty directories are created by libtorrent and has been fixed in lt 0.16.