Deluge
#2401 closed bug (Fixed)
right-click download limit dialog doesnt show whats set
| Reported by: | philipz | Owned by: | Cas |
|---|---|---|---|
| Priority: | minor | Milestone: | 2.x |
| Component: | GTK UI | Version: | 1.3.6 |
| Keywords: | Cc: |
Description
the maximum download speed dialog that appears after right-clicking on a torrent, then options, then download speed limit, then other... doesnt display what the current download speed was previously set at, instead it shows '-1'.
Change History (7)
comment:1 Changed 10 years ago by philipz
- Version changed from other (please specify) to 1.3.6
comment:2 Changed 10 years ago by Cas
- Component changed from Console to GTK-UI
- Milestone changed from Future to 1.3.7
comment:3 Changed 10 years ago by OmegaPhil
- Status changed from new to assigned
Cas has nominated me to look at this as part of the #2400 work. I can see that this menu code is hardcoded to use default values in all the various options cases. I intend to have it fetch the current torrent state when one torrent is selected, otherwise use the default.
See ui/gtkui/menubar.py:MenuBar.on_menuitem_set_other, other_dialog_info
comment:4 Changed 10 years ago by OmegaPhil
- Owner set to OmegaPhil
comment:5 Changed 10 years ago by Cas
- Milestone changed from 1.3.7 to 1.4.0
- Owner changed from OmegaPhil to Cas
I was looking to get this into next release but this is a much bigger change than I realised. It requires adding a deferred to the Other dialog, otherwise it will never close.
Moving this to 1.4 milestone.
@OmegaPhil I have got working code: https://github.com/cas--/Deluge/tree/Bug/develop/2401/Other_dialog_current_value
comment:6 Changed 10 years ago by Cas
- Resolution set to Fixed
- Status changed from assigned to closed
Fixed in develop: [ea7ef950a3]
The component is not the console.