Opened 10 years ago

Closed 8 years ago

Last modified 7 years ago

#2474 closed patch (Invalid)

Replace add_torrent with async_add_torrent

Reported by: Doadin Owned by:
Priority: minor Milestone: 2.x
Component: Core Version: develop
Keywords: Cc:

Description

http://dev.deluge-torrent.org/wiki/Plan/libtorrent

Other potential changes Replace add_torrent with the more efficient non-blocking async_add_torrent.

Attachments (1)

Replace add_torrent with async_add_torrent.patch (4.1 KB ) - added by Doadin 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Calum, 10 years ago

I'm afraid that patch is incorrect plus it is more complicated than simply renaming the method call to libtorrent.

From lt man:

In order to add torrents more efficiently, consider using async_add_torrent() which returns immediately, without waiting for the torrent to add. Notification of the torrent being added is sent as add_torrent_alert.

Last edited 10 years ago by Calum (previous) (diff)

comment:2 by Doadin, 10 years ago

I was just starting to work on it. Mostly just opened this because there isnt a ticket for this item yet? So more just a spot to work on it and add patches and what not so its easy to collaborate on the issue.

comment:3 by Calum, 10 years ago

I appreciate the ticket being opened but the patch is no good, clearly untested and changes code that is irrelevant to the issue.

comment:4 by Doadin, 8 years ago

Resolution: Invalid
Status: newclosed

comment:5 by Calum, 7 years ago

Milestone: 2.0.x2.x

Milestone renamed

Note: See TracTickets for help on using tickets.