Opened 7 years ago

Closed 5 years ago

Last modified 3 years ago

#2477 closed bug (Fixed)

Incorrect number of torrents being shown

Reported by: Doadin Owned by:
Priority: minor Milestone: 2.0.0
Component: GTK UI Version: develop
Keywords: Cc:

Description

After adding 800 torrents though autoadd the number of torrents is incorrect. There was 83 already added and i added around 800 the "all" in the side bar still reads 83 but says there are 904 paused. Which is all of them. Adding a few at a time it seems to work fine. Perhapse a check of some sort should be added to ensure correct numbers are shown?

Note: Also changing the torrent state pause to download or vice versa the number downloading or paused changes correctly but the "all" is still incorrect. Maybe some kinda of check like if (paused+queued+downloading+seeding) != (all)

allstatescombined = (paused+queued+downloading+seeding) all = allstatescombined

Obviously of this bit is of no use anywhere but thats the idea. And obiously i think theres at least 1 state missing from that list.

Attachments (1)

deluge wrong number of all torrents.jpg (151.2 KB) - added by Doadin 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Doadin

comment:1 Changed 7 years ago by Doadin

It does appear to fix after reloading the daemon. I guess you could close this.

comment:2 Changed 7 years ago by Cas

  • Component changed from other/unknown to GTK-UI

It is an issue that has been noticed and we should look into fixing it.

Last edited 7 years ago by Cas (previous) (diff)

comment:3 Changed 7 years ago by Doadin

Just in case should be noted its not in just the gtkui its webui too as its comeing from the core/libtorrent.

comment:4 Changed 7 years ago by Doadin

Just wanted to add that the "All" under Trackers and "Admin" under owner(the only owner) shows the right number. So it appears maybe their just needs to be some kind of event to update the "All" under states? The number is off till a restart of the daemon when adding or removing a torrent. So maybe something in the add_torrent and remove_torrent that like it does on startup reads?adds? the total?(not sure how its done)

comment:5 Changed 7 years ago by Cas

  • Milestone changed from 2.0.x to 2.0

comment:6 Changed 5 years ago by Doadin

  • Status changed from new to pending

seems like to me on windows build something between builds deluge-2.0.0.dev584(https://github.com/deluge-torrent/deluge/commit/10e1a2a5937771efda53a0e7fcb82a407c5fc841)-deluge-2.0.0.dev603(https://github.com/deluge-torrent/deluge/commit/47f14845ca49f7eaf9fbb9672441538edc3f0722) this issue has been fixed? As far as i can tell i have it running in thin client ive restarted daemon and ui a couple times and added 1 torrent or ~20 torrents removed 1 torrent or removed ~3,~5, and all along the way the number has stayed correct. There also seems to be a new status category that i dont remember seeing before, "Active" which shows up when any torrent is transferring data. Maybe there was a issue with processing the categorys before whcih caused the glitch/bug? idk

Last edited 5 years ago by Doadin (previous) (diff)

comment:7 Changed 5 years ago by Cas

  • Resolution set to Fixed
  • Status changed from pending to closed

I'm pretty sure bendik mentioned something about fixing torrent count in one of the commits.

Active has always been a state, it perhaps has not been working correctly recently.

comment:8 Changed 5 years ago by Doadin

Ah maybe he did and i hadnt noticed. Either way seems to be ok now. And yea i think i remember seeing active with older stable builds maybe? but ever since the count was off i hadnt noticed it. Either way good news hes squashing bugs left and right. :)

Last edited 5 years ago by Doadin (previous) (diff)

comment:9 Changed 5 years ago by bro

Just reverted one of my earlier commits to fix this bug :-)

With the changes in PR6 eventually getting merged, that small (buggy) optimization seemed better in a reverted state.

comment:10 Changed 3 years ago by Cas

  • Milestone changed from 2.0 to 2.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.