Changes between Initial Version and Version 1 of Ticket #2496, comment 1


Ignore:
Timestamp:
08/31/2014 09:44:42 AM (10 years ago)
Author:
awknaust
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2496, comment 1

    initial v1  
    11I think I've traced this to a bug in addtorrentdialog.py. It relies on a deferred object to get the config values and set the core_config dictionary. This deferred is called either from start() or show(). However when you add a torrent it eventually goes to add_from_files, which calls set_default_options, assuming core_config is already loaded.  
    22 
    3 Unfortunately when this assumption fails, it throws an error, and doesn't open the add torrent dialog. The queued torrents dialog assumes adding will always be successful, so it clears its queue own queue. 
     3Unfortunately when this assumption fails, it throws an error, and doesn't open the add torrent dialog. The queued torrents dialog assumes adding will always be successful, so it clears its own queue. 
     4 
    45 
    56This problem is probably also present with add_from_magnets, add_from_url 
     7 
     8I'd like to write a patch, but I'm just a beginner with deluge/twisted. Should you somehow block on the core config, or just call update_core_config again in add_from_files and split the rest of it into a callback?