Opened 9 years ago
Closed 9 years ago
#2777 closed bug (Fixed)
Update NSIS MSVC redist checker
| Reported by: | lunch | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3.13 |
| Component: | Packaging | Version: | 1.3.12 |
| Keywords: | Cc: |
Description
Currently the installer doesn't check for the latest versions of Visual C++ 2008 Redistributable. As a result, if the user has the latest version of these runtimes installed, it isn't recognized and he is prompted to install these. As more, an older version.
Relevant file: deluge-win32-installer.nsi
CLSID currently checked:
FF66E9F6-83E7-3A3E-AF14-8DE9A809A6A4 9A25302D-30C0-39D9-BD6F-21E6EC160475
You should add these two entries:
1F1C2DFC-2D24-3E06-BCB8-725134ADF989 9BE518E6-ECC6-35A9-88E4-87755C07200F
I think you should also remove FF66E9F6-83E7-3A3E-AF14-8DE9A809A6A4, so the user would be prompted to update its antiquated VC++ 2008 redistributable to at least SP1.
Lastly, I would update the download link to https://www.microsoft.com/en-us/download/details.aspx?id=26368 in order to direct to the latest version.
References:
http://blogs.msdn.com/b/astebner/archive/2009/01/29/9384143.aspx http://stackoverflow.com/questions/11056812/where-to-download-vcredist#12103985 https://support.microsoft.com/en-us/kb/2977003#bookmark-vs2008
Fixed 1.3-stable: [5464cf674aa6c]