Opened 8 years ago
Closed 6 years ago
#2786 closed bug (Fixed)
[GTKUI][Connection Manager] Dialog Wont Show, Errno 11001
Reported by: | Doadin | Owned by: | Cas |
---|---|---|---|
Priority: | minor | Milestone: | 1.3.15 |
Component: | GTK UI | Version: | develop |
Keywords: | Cc: | bro |
Description
If you enter a improper/nonexistant ip soemthing like 999.999.999.999 the connection dialog accepts this but apon closing the dialog it then will not reopen giving error "socket.gaierror: [Errno 11001] getaddrinfo failed". I suggest a check of hostname ips entered to prevent this.
Change History (8)
comment:1 Changed 8 years ago by bro
- Cc bro added
- Owner set to bro
- Status changed from new to accepted
comment:2 Changed 8 years ago by bro
comment:3 Changed 7 years ago by Cas
The fix for this should be ui side so check with is_ip() when creating an entry.
comment:4 Changed 7 years ago by Doadin
comment:5 Changed 7 years ago by Doadin
is_ip cant be use? unless we want to limit to ip addresses only and not host names like localhost?
comment:6 Changed 7 years ago by Cas
- Milestone changed from Future to 2.0
comment:7 Changed 6 years ago by Cas
- Milestone changed from 2.0 to 1.3.15
- Owner changed from bro to Cas
- Priority changed from major to minor
- Status changed from accepted to assigned
comment:8 Changed 6 years ago by Cas
- Resolution set to Fixed
- Status changed from assigned to closed
I revisited this to make sure both user entry caught invalid ips and parsing hostlist would not prevent connection manager showing. Thanks bro for original code :)
Fixed develop [d485eb5c8f1e] and 1.3-stable: [08c03d76785128]
Patch for 1.3: https://github.com/deluge-torrent/deluge/pull/53
Patch for develop: https://github.com/deluge-torrent/deluge/pull/54