Opened 9 years ago
Closed 8 years ago
#2786 closed bug (Fixed)
[GTKUI][Connection Manager] Dialog Wont Show, Errno 11001
Reported by: | Doadin | Owned by: | Calum |
---|---|---|---|
Priority: | minor | Milestone: | 1.3.15 |
Component: | GTK UI | Version: | develop |
Keywords: | Cc: | Bro |
Description
If you enter a improper/nonexistant ip soemthing like 999.999.999.999 the connection dialog accepts this but apon closing the dialog it then will not reopen giving error "socket.gaierror: [Errno 11001] getaddrinfo failed". I suggest a check of hostname ips entered to prevent this.
Change History (8)
comment:1 by , 9 years ago
Cc: | added |
---|---|
Owner: | set to |
Status: | new → accepted |
comment:2 by , 9 years ago
comment:3 by , 8 years ago
The fix for this should be ui side so check with is_ip() when creating an entry.
comment:5 by , 8 years ago
is_ip cant be use? unless we want to limit to ip addresses only and not host names like localhost?
comment:6 by , 8 years ago
Milestone: | Future → 2.0 |
---|
comment:7 by , 8 years ago
Milestone: | 2.0 → 1.3.15 |
---|---|
Owner: | changed from | to
Priority: | major → minor |
Status: | accepted → assigned |
comment:8 by , 8 years ago
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
I revisited this to make sure both user entry caught invalid ips and parsing hostlist would not prevent connection manager showing. Thanks bro for original code :)
Fixed develop [d485eb5c8f1e] and 1.3-stable: [08c03d76785128]
Patch for 1.3: https://github.com/deluge-torrent/deluge/pull/53
Patch for develop: https://github.com/deluge-torrent/deluge/pull/54