Opened 8 years ago

Closed 8 years ago

#2790 closed bug (Fixed)

Inform user of invalid magnet uri

Reported by: MarcosRamirez Owned by: Cas
Priority: trivial Milestone: 1.3.13
Component: Core Version: 1.3.12
Keywords: magnet, fails Cc:

Description

Hi,

First of all:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 14.04.4 LTS
Release:  14.04
Codename: trusty

Problem is, i try to configure to manage magnet links with Chrome:

gvfs-mime --set x-scheme-handler/magnet deluge.desktop

and seems to deluged gets opened, but, does nothing

gvfs-mime --set x-scheme-handler/magnet deluge.desktop

Then, i tune /usr/share/applications/deluge.desktop file but no one of this works:

Exec=deluge %U
Exec=deluge "%U"
Exec=deluge %s
Exec=deluge "%s"
Exec=deluge-gtk %U
Exec=deluge-gtk "%U"
Exec=deluge-gtk %s
Exec=deluge-gtk "%s"

Then, i try to run it manually from the console:

$ deluge "magnet:?xt=urn:btih:mvlzouqb5jqfhqlktgnaortday5ihzbb&dn=The+walking+dead+-+5x01+%28EliteTorrent.net%29&tr=http://tracker.torrentbay.to:6969/announce"

With same result, seems like's deluged get called, but nothing added (see screenshot)

Then i try to add it via "ctrl+o", but, does nothin... and i get blocked here...

Dunno wha more can i do.

Change History (6)

comment:1 Changed 8 years ago by Cas

  • Component changed from other/unknown to GTK-UI
  • Milestone changed from needs verified to 1.3.13
  • Priority changed from major to trivial
  • Summary changed from fails opening magnet links (via CTRL+O, command line or browser integration) to Inform user of invalid magnet uri

As per BugReporting if you enabled logging you would find that magnet uri is invalid: exceptions.TypeError: Non-base32 digit found

It might be helpful to inform the user of this in the UI however.

comment:2 Changed 8 years ago by Cas

Looking again at your magnet it seems you have somehow ended up with a magnet uri containing a lower-case base32 hash mvlzouqb5jqfhqlktgnaortday5ihzbb which is invalid so if you replace it with MVLZOUQB5JQFHQLKTGNAORTDAY5IHZBB it will work.

comment:3 Changed 8 years ago by andar

Maybe we could string.toupper() on magnet links to help in this situation?

comment:4 Changed 8 years ago by Cas

It's a very edge case but I was thinking that too :)

comment:5 Changed 8 years ago by Cas

  • Owner set to Cas
  • Status changed from new to assigned

Fixed in develop: [cd6669c0245]

comment:6 Changed 8 years ago by Cas

  • Component changed from GTK UI to Core
  • Resolution set to Fixed
  • Status changed from assigned to closed

Fixed in 1.3-stable: [ad58fca1f9eb3b0]

Note: See TracTickets for help on using tickets.