Path inconsistency while escaping whitespace

[Joe96]

While adding a torrent using a command similar to this:

deluge-console add -p 'C:\Path\With Spaces' D:\my_torrent_file.torrent

, if what the torrent downloads contains folders, the download path will be something like this:

C:\\Path\\With Spaces\\torrent_folder\torrent_file.txt

And that single slash ("\") is inconsistent with the others, therefore, deluge returns the error

The filename, directory name, or volume label syntax is incorrect: C:\\Path\\With Spaces\\torrent_folder\torrent_file.txt

Paths containing no white spaces, or torrents that do not have a folder in their download do not have this issue.

Image: ​http://i.imgur.com/m5g77nv.png

[Joe96]

In

deluge\ui\console\commands\add.py

on line 62, there is:

t_options["download_location"] = os.path.expanduser(options["path"])

I changed that to

t_options["download_location"] = os.path.abspath(options["path"])

And it seems to work fine. abspath turns the double slashes into single slashes, while expanduser doesn't.

[andar]

Why not both?

[Joe96]

Actually, you're right. I excluded the os.path.expanduser because i don't need it. The reason i used the deluge-console add command was because i wanted to make a python script that adds new torrents automatically, and the path i provide is always the full path, but to address this bug, the correct fix would be

t_options["download_location"] = os.path.abspath(os.path.expanduser(options["path"]))

[Calum]

Just to note abspath calls ​`normpath` which is what actually fixes this issue. It's helpful however using abspath in this case as a relative folder could also be provided.

[Calum]

Fixed 1.3-stable: [a1e66a4dc154]

Will also need fixing in develop

[Calum]

develop: [ec5c8bafb6]