Opened 8 years ago

Closed 8 years ago

#2829 closed bug (Fixed)

Scheduler plugin cannot be disabled

Reported by: 5haffl Owned by:
Priority: major Milestone: 1.3.13
Component: Plugin Version: 1.3.12
Keywords: scheduler, plugin, disable, session_set_setting, do_config_set_func Cc:

Description

Hi,

When trying to disable the Scheduler plugin via deluge-web, I get the following error message from deluged (deluged -L error):

[ERROR   ] 13:34:40 init:57 Unable to disable plugin!
[ERROR   ] 13:34:44 init:58 'PreferencesManager' object has no attribute 'do_config_set_func'
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/deluge/plugins/init.py", line 55, in disable
    self.plugin.disable()
  File "/usr/lib/python2.7/dist-packages/deluge/plugins/Scheduler-0.2.egg/scheduler/core.py", line 114, in disable
    self.__apply_set_functions()
  File "/usr/lib/python2.7/dist-packages/deluge/plugins/Scheduler-0.2.egg/scheduler/core.py", line 130, in __apply_set_functions
    component.get("PreferencesManager").do_config_set_func(setting, core_config[setting])
AttributeError: 'PreferencesManager' object has no attribute 'do_config_set_func'

Therefore, the plugin cannot be disabled. I've already made a pull request for this bug, which can be solved simply by replacing do_config_set_func with session_set_setting in core.py (line 130) of the Scheduler plugin, according to the actual name of the method defined in core/preferencesmanager.py

Attachments (1)

Scheduler-0.3-py2.7.egg (25.9 KB ) - added by Calum 8 years ago.
Fixed plugin version from 1.3-stable

Download all attachments as: .zip

Change History (2)

comment:1 by Calum, 8 years ago

Milestone: needs verified1.3.13
Resolution: Fixed
Status: newclosed

Has already been fixed in 1.3-stable for next release: [cdf301601fe71bd697f37]

There was a discussion in the forum: http://forum.deluge-torrent.org/viewtopic.php?t=52553

by Calum, 8 years ago

Attachment: Scheduler-0.3-py2.7.egg added

Fixed plugin version from 1.3-stable

Note: See TracTickets for help on using tickets.