Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#2882 closed bug (Fixed)

load_country_db was removed from python bindings

Reported by: braiam Owned by:
Priority: minor Milestone: 2.0.0
Component: libtorrent Version: 1.3.12
Keywords: Cc:

Description

Here's the pull request https://github.com/arvidn/libtorrent/pull/930 which was suggested to fix this issue https://github.com/arvidn/libtorrent/issues/927 :

[ERROR   ] 00:42:41 preferencesmanager:502 Unable to load geoip database!
[ERROR   ] 00:42:41 preferencesmanager:503 'session' object has no attribute 'load_country_db'
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/deluge/core/preferencesmanager.py", line 500, in _on_geoip_db_location
    self.session.load_country_db(str(geoip_db))
AttributeError: 'session' object has no attribute 'load_country_db'

Funtionality wise it seems to be fine, but if we are not expecting load_country_db to be present, we should fail more gracefully.

Change History (4)

comment:1 Changed 5 years ago by braiam

  • Version changed from other (please specify) to 1.3.12

comment:3 Changed 5 years ago by Cas

  • Milestone changed from needs verified to 2.0
  • Resolution set to Fixed
  • Status changed from new to closed

This is now caught in develop [aa164cdbcea86] and improved the log message for 1.3: [6c73105a7307508]

The actual fix is to implement #2861

comment:4 Changed 3 years ago by Cas

  • Milestone changed from 2.0 to 2.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.