Opened 13 years ago

Closed 13 years ago

#307 closed bug (Fixed)

Some UI update patches

Reported by: sadrul Owned by: andar
Priority: minor Milestone:
Component: GTK UI Version: 0.6.0svn
Keywords: Cc:

Description

I am going to attach a couple of patches in here for some minor UI updates:

  • gtkui_preference_toggle_updates.patch:

Makes the filechooser buttons [in]sensitive depending on the state of the corresponding checkbuttons in the preference dialog. Does the same check for the 'Stop seeding' setting too.

  • gtkui_disable_options_tab.patch:

When no torrent is selected in the torrentview, the tabs at the bottom (Statistics, Details etc.) are cleared, except 'Options'. This patch makes the child widgets within the tab insensitive. I also considered hiding the child widget, but making them insensitive looked better :)

  • gtkui_update_main_window_torrents_menu.patch:

This updates the 'Torrent' menu in the main window as the selection in the torrent-view is changed. With the current patch, the menu is enabled only if at least one torrent is selected, otherwise it's disabled. The Pause/Resume/Remove? menuitems should probably be disabled/enabled using the same logic as those used in toolbar.py:update_buttons. But this patch doesn't include that part, since I thought perhaps it'd be good to not have to duplicate the same logic in two places.

Attachments (3)

gtkui_preference_toggle_updates.patch (6.8 KB) - added by sadrul 13 years ago.
gtkui_disable_options_tab.patch (632 bytes) - added by sadrul 13 years ago.
gtkui_update_main_window_torrents_menu.patch (2.9 KB) - added by sadrul 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by sadrul

Changed 13 years ago by sadrul

comment:1 Changed 13 years ago by andar

  • Resolution set to fixed
  • Status changed from new to closed

Committed [3305]. Thanks!

Note: See TracTickets for help on using tickets.