Opened 13 months ago

#3167 new bug

tracker_icons.py does not clean up /tmp entries from failed hosts

Reported by: rexar Owned by:
Priority: minor Milestone: needs verified
Component: GTK UI Version: 1.3.15
Keywords: icons tracker_icons Cc:

Description

If Deluge attempts to obtain a tracker icon for a tracker that is unreachable, or has a re-direct to self (perpetual HTTP 301/302) the errorback routines in tracker_icons.py do not have access to the temporary filehandles / paths created as part of the download_page method, and as such is unable to clean up these pre-allocated resources.

Over a period of time under Linux, this fills the /tmp directory with a large amount of junk files in the form of deluge_ticon.xxxxx

Attached is a workaround targetting the 1.3.15 release version of tracker_icons.py which allows the errorback routines to clean files allocated from failed attempts.

This was developed against my scenario which is the GTK client connecting to a remote server, it hasn't been tested for other use cases.

Attachments (1)

tracker_icons.patch (4.1 KB) - added by rexar 13 months ago.
Patch file against 1.3.15 release version of tracker_icons.py

Download all attachments as: .zip

Change History (1)

Changed 13 months ago by rexar

Patch file against 1.3.15 release version of tracker_icons.py

Note: See TracTickets for help on using tickets.