GTK Notification plugin error

[Calum]

User reported these three errors while running the plugin

12:15:51.490 [CRITICAL][twisted :154 ] Unhandled error in Deferred: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 322, in addCallback callbackKeywords=kw) 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 311, in addCallbacks self._runCallbacks() 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 654, in _runCallbacks current.result = callback(current.result, *args, **kw) 
File "/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg/deluge_notifications/gtkui.py", 
line 161, in handle_custom_sound_notification self.__play_sound, self.config['custom_sounds'][eventtype] --- <exception caught="" here=""> --- 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 151, in maybeDeferred result = f(*args, **kw) 
File "/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg/deluge_notifications/gtkui.py", line 194, in __play_sound return defer.fail(err_msg) File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 108, in fail d.errback(result) 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 499, in errback fail = failure.Failure(fail) 
File "/usr/lib/python3/dist-packages/twisted/python/failure.py", 
line 249, in __init__ raise TypeError("Strings are not supported by Failure") builtins.TypeError: Strings are not supported by Failure 

12:15:51.497 [CRITICAL][deluge.log :93 ] twisted.internet.defer 
[Failure instance: 

Traceback: 
<class 'typeerror'="">: argument value: Expected GLib.Variant, but got str 
/usr/lib/python3/dist-packages/twisted/internet/defer.py:322:addCallback 
/usr/lib/python3/dist-packages/twisted/internet/defer.py:311:addCallbacks 
/usr/lib/python3/dist-packages/twisted/internet/defer.py:654:_runCallbacks 
/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg/deluge_notifications/gtkui.py:147:handle_custom_popup_notification 
--- <exception caught="" here=""> --- 
/usr/lib/python3/dist-packages/twisted/internet/defer.py:151:maybeDeferred 
/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg
/deluge_notifications/gtkui.py:181:__popup ] 

12:18:28.697 [CRITICAL][twisted :154 ] Unhandled error in Deferred: 
Traceback (most recent call last): 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 322, in addCallback callbackKeywords=kw) 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 311, in addCallbacks self._runCallbacks() 
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 654, in _runCallbacks current.result = callback(current.result, *args, **kw) 
File "/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg/deluge_notifications/gtkui.py", 
line 147, in handle_custom_popup_notification return defer.maybeDeferred(self.__popup, title, message) 
--- <exception caught="" here=""> ---
File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", 
line 151, in maybeDeferred result = f(*args, **kw) File "/usr/lib/python3/dist-packages/deluge/plugins/Notifications-0.3.egg/deluge_notifications/gtkui.py", 
line 181, in __popup self.note.set_hint('desktop-entry', 'deluge') builtins.TypeError: argument value: Expected GLib.Variant, but got str 

[Calum]

Ticket retargeted after milestone closed

[Alexey]

Hello! I'm having something similar.
OS: Arch Linux.
DE: i3wm(4.16.1).
Deluge Version: 2.0.3

When download is finished, i get this in the terminal:

Unhandled error in Deferred:
17:40:38 [CRITICAL][twisted                           :154 ] Unhandled error in Deferred:
17:40:38 [CRITICAL][twisted                           :154 ] Unhandled error in Deferred:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/twisted/internet/defer.py", line 322, in addCallback
    callbackKeywords=kw)
  File "/usr/lib/python3.7/site-packages/twisted/internet/defer.py", line 311, in addCallbacks
    self._runCallbacks()
  File "/usr/lib/python3.7/site-packages/twisted/internet/defer.py", line 654, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py", line 147, in handle_custom_popup_notification
    
--- <exception caught here> ---
  File "/usr/lib/python3.7/site-packages/twisted/internet/defer.py", line 151, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py", line 181, in __popup
    
builtins.TypeError: argument value: Expected GLib.Variant, but got str

17:40:38 [CRITICAL][deluge.log                        :93  ] twisted.internet.defer 
[Failure instance: Traceback: <class 'TypeError'>: argument value: Expected GLib.Variant, but got str
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:322:addCallback
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:311:addCallbacks
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:654:_runCallbacks
/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py:147:handle_custom_popup_notification
--- <exception caught here> ---
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:151:maybeDeferred
/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py:181:__popup
]
17:40:38 [CRITICAL][deluge.log                        :93  ] twisted.internet.defer 
[Failure instance: Traceback: <class 'TypeError'>: argument value: Expected GLib.Variant, but got str
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:322:addCallback
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:311:addCallbacks
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:654:_runCallbacks
/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py:147:handle_custom_popup_notification
--- <exception caught here> ---
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:151:maybeDeferred
/usr/lib/python3.7/site-packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/gtkui.py:181:__popup
]

I didn't have this issue in previous versions of deluge.

[int3l]

Fix: ​GitHub PR: Fix argument type for the notification popup hint

[Alexey]

Replying to int3l:

Fix: ​GitHub PR: Fix argument type for the notification popup hint

Works great now, many thanks!

[Calum]

Fixed: [63a4301a8be8]