Label plugin unable to reopen label options

[Calum]

From a forum user: ​https://forum.deluge-torrent.org/viewtopic.php?f=7&t=55394

Attached is a short screen recording to show how the context menu behavior looks like. After I close the first modal, the context menu opens, but any click on "Label Options" does nothing. The functionality of the add or remove label entries is intact. In the process of this testing I also found the attached console error about it. I'm wondering why I didn't see that the first time around.

[Calum]

From my quick testing it looks like clicking the dialog X button or pressing the Esc key results in the dialog unable to re-open and a similar console error:

TypeError: me.dom is undefined ext-all-debug.js:8073:15
    ExtJS 4
    show http://localhost:8112/js/label/label.js:398
    onLabelOptionsClick http://localhost:8112/js/label/label.js:609
    ExtJS 5
        fire
        fireEvent
        onClick
        onClick
        h

Using the OK or Cancel buttons works fine.

[DjLegolas]

This happens with the add button too.

And I found the cause, and fixed it. PR: ​252.

[Calum]

Fixed: [3f9ae337932d]