Changes between Version 1 and Version 2 of Ticket #3295, comment 6


Ignore:
Timestamp:
06/23/2021 08:49:14 PM (3 years ago)
Author:
mhertz

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3295, comment 6

    v1 v2  
    55"I previously posted a version in other thread, which just unbroke magnet support, but this here is full fix, so no .magnet files labeled .invalid anymore for no reason, is correctly deleted/renamed after adding, and labels work again for them.
    66
    7 The issue btw was that add_torrent_magnet() isn't returning a defered object like add_torrent_file_async(), so the scheduled deferred of magnets never ran and error'ed out with attribute-error(as the returned torrent_id string didn't have no addCallback attribute i.e. not a deferred), and at next poll-interval would try readd, fail and hence rename .invalid, so I changed the call for magnets from a twisted addCallback into instead direct function call, and added the addCallback/addErrback only for torrents and not magnets."
     7The issue btw was that add_torrent_magnet() isn't returning a defered object like add_torrent_file_async(), so the scheduled deferred of magnets never ran and error'ed out with attribute-error(as the returned torrent_id string didn't have no addCallback attribute i.e. not a deferred), and disables watchdir. Pre-Cas fix, then on_torrent_added() never called for magnets, and so at next poll-interval would try readd, fail and hence rename .invalid. Anyway, so I changed the call for magnets from a twisted addCallback into instead direct function call, and added the addCallback/addErrback only for torrents and not magnets, making magnets and labels work again."