Runtime error in Windows when maximizing

[cinderblock]

If you maximize the Deluge GTK window in Windows (only tested in Thin client), a runtime error occurs.

Program: ...\cairo.dll
File: cairo-surface.c
Line: 955

Expression: CAIRO_REFERENCE_COUNT_HAS_REFERENCE(&surface->ref_count)

If you "ignore", the interface seems to work, but breaks when doing anything useful.

[cinderblock]

Error window

[MrNerdHair]

Another error; this time from Win10 2004, using deluge-2.0.3-lt1.2.10-boost1.74-py3.8.5-ossl1.1.1g-GTK3.24.23.exe from ​https://github.com/petersasi/deluge2-win-build.

[Cas]

This might be related to using the pieces progress bar, can you try disabling that

[Cas]

The Stats plugin also uses cairo so that might also be a cause of crash here

[Cas]

I am going to put this on the 2.1 milestone but I suspect it will need fixing upstream in cairo since seems isolated to Windows

[Cas]

Ticket retargeted after milestone closed

[Cas]

I have a potential fix but not tested it on Windows to confirm

​https://github.com/deluge-torrent/deluge/pull/431

[mhertz]

Awesome, thanks Cas, I tested your PR working in my test win10 VM, thanks! I actually tried when you initially posted, but couldn't reproduce then, but now searched my older posts and recalled it doesn't happen anymore unless overriding default GTK_CSD=0, so I did, and with window not maximized I resized it through dragging left border little to left, and immediate crash without your fix and fine with it, atleast in testing 3 tries each with/without, and both stats and pieces enabled in prefs. Thanks again!

[Cas]

Excellent thanks for testing and confirming!