Opened 4 months ago

#3382 new patch

Notifications-0.3: improve smtplib.SMTP.sendmail() error logging

Reported by: lalbornoz Owned by:
Priority: minor Milestone: needs verified
Component: Plugin Version: 2.0.3
Keywords: notifications Cc:

Description

The Notifications plugin as of version 0.3 only includes the value of an smtplib.SMTPException implicitly converted to a string in the log file on error:

Apr 11 15:06:08 [REDACTED] deluged[31554]: 15:06:08 [ERROR   ][deluge_notifications.core     :160 ] There was an error sending the notification email: {}

The patch enclosed includes both the exception type inasmuch as value in the logged error to aid debugging, e.g. yielding:

Apr 11 15:19:41 [REDACTED] deluged[539]: 15:19:41 [ERROR   ][deluge_notifications.core     :162 ] There was an error sending the notification email: <class 'smtplib.SMTPRecipientsRefused'>, {} 

Attachments (1)

deluge-2.0.3+smtp_errors_Notifications_plugin.patch (868 bytes) - added by lalbornoz 4 months ago.

Download all attachments as: .zip

Change History (1)

Note: See TracTickets for help on using tickets.