Changes between Initial Version and Version 1 of Ticket #3440, comment 1


Ignore:
Timestamp:
02/06/2021 12:22:31 PM (3 years ago)
Author:
Cas
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3440, comment 1

    initial v1  
    1 We need more a bit information about the exact problem. Are the torrent downloads in UTF8 and decoding with Windows-1251 is corrupting the data? What is the error you are encountering?  
     1We need more a bit information about the exact problem. Are the torrent downloads corrupted decoding with Windows-1251? What is the error you are encountering?  
    22 
    3 I am wary of changing the way httpdownloader works as it could have unintended consequences.  
     3I am wary of changing the way httpdownloader works as it could have unintended consequences but I understand your reasoning for specifying text content type only re-encoding. 
    44 
    5 I would propose to not re-encode application/x-bittorrent (it should be utf8...) so in request_callback don't set encoding if content-type is application/x-bittorrent.  
     5I would perhaps propose to just not re-encode application/x-bittorrent (it should be binary...) so in request_callback don't set encoding if content-type is application/x-bittorrent.  
    66 
    77{{{