Cannot add host on deluge-console (invalid port)

[tremby]

The "add host" option in deluge-console does not work.

I think the integer validation intended for the port field is checking the contents of the host field, or something similar.

If I type in a string in the host field and a number in the port field, I get "Error adding host -- localhost: Invalid port. Must be an integer".

Interestingly, if I fill the port number in to the host field, and the hostname in to the port field, I get "58846: Invalid port. Must be an integer".

[KtlTheBest]

Good time of the day. I am currently looking into the problem, but the quick analysis shows that there is no conversion of port value to integer.

There is a _do_add(result, **kwargs) method in ui/console/modes/connectionmanager.py which then calls add_host(hostname, port, username, password) method from the same class, which in turn calls the add_host() from the Hostlist() class which is located in ui/hostlist.py which then raises the Exception.

The question is, at what stage does the conversion from the str to int must happen?

Best regards, KtlTheBest?

[Cas]

In the console connectionmanager I can see it is using add_text_input, could try replacing it with an int input field e.g. add_int_spin_input

[Cas]

Ticket retargeted after milestone closed

[blob42]

This fixed it for me:

   # cast port to int in ui/console/modes/connectionmanager.py
   self.hostlist.add_host(hostname, int(port), username, password)