Opened 2 years ago

Closed 2 years ago

#3530 closed bug (Fixed)

Trackers are not added through magnets.

Reported by: mhertz Owned by:
Priority: minor Milestone: 2.1.1
Component: Core Version: 2.1.0
Keywords: Cc:

Description

As title, optional trackers defined in magnet URI's with '&tr=' args, isn't applied e.g. in GTK-UI when pressing 'add' without metadata-prefetching finished yet / filelist empty. If in GTK-UI waiting until prefetching finished / file(s) listed, then does work however. Same issue when adding magnets with optional trackers through 'deluge-console add' command.

It's irrelevant which libtorrent version used, but happens in deluge 2.1.0 but not 2.0.5 and down. I narrowed it further down specifically to commit 2bd095e being the culprit: https://github.com/deluge-torrent/deluge/commit/2bd095e5bfc49cbe178fc0ba9df38b88afc238aa

Issue originally found and reported by nemonein in following forum-thread: https://forum.deluge-torrent.org/viewtopic.php?f=7&p=235005#p235005

Thanks alot in advance!

Change History (2)

comment:1 Changed 2 years ago by mhertz

Just wanted to add that I found the culprit from commit 2bd095e being this removed line from torrentmanager.py:

@@ -436,14 +438,10 @@ def _build_torrent_params(
         elif magnet:
             magnet_info = get_magnet_info(magnet)
             if magnet_info:
-                add_torrent_params['url'] = magnet.strip().encode('utf8')
                 add_torrent_params['name'] = magnet_info['name']
                 torrent_id = magnet_info['info_hash']

Adding back said line into new line 438 of torrentmanager.py in current develop fixes issue.

comment:2 Changed 2 years ago by Cas

  • Milestone changed from needs verified to 2.1.1
  • Resolution set to Fixed
  • Status changed from new to closed
  • Version changed from develop to 2.1.0

Thanks for investigating, it does look like while removing deprecated url param the trackers were overlooked since lt would normally extract them from url.

Fixed: [f52cf760e4934f1]

Note: See TracTickets for help on using tickets.