Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#646 closed bug (Fixed)

Seeding - bad share ratio

Reported by: slush@… Owned by: andar
Priority: trivial Milestone:
Component: GTK UI Version: 1.0.6
Keywords: Cc:

Description

Hi,

I found that share ratio is always infinite, when I'm only seeding torrent. I expect, that share ratio is not counted only from "Upload/Download?" size (bec. Download = 0), but "Upload/Size?" in case of seeding. This is behaviour of 0.x line of Deluge and I like it.

Currently, there is no indicator of seed ratio. I have to check "Uploaded" manually on torrent tab.

Change History (5)

comment:1 Changed 12 years ago by andar

Yes, I was trying to find the best way to calculate share ratio and sort of just left it with a: uploaded / downloaded

It could be when downloaded == 0, then use total_done (how much of the torrent you _have_, doesn't need to be downloaded), but I thought this might be misleading for what a share ratio should be, since it is essentially the ratio between what you've uploaded and downloaded. Maybe I'm being too strict with the definition?

comment:2 Changed 12 years ago by andar

  • Milestone set to 1.1.0
  • Resolution set to fixed
  • Status changed from new to closed

I've gone ahead and made this change in [4357]

comment:3 Changed 12 years ago by slush@…

I think it is bad idea to divide algorithm between downloaded == 0 and downloaded > 0. As I think about share ratio, it should be upload/(size of finished blocks). It gives right size for both situation and make sense in common usage.

As you said, you are strict and I understand you. From side of definition of share ration, you are absolutely right. But you also can use share ratio as some numeric representation of your "tendency to seed". With this aspect, I think, is not important, how much you download.

comment:4 Changed 12 years ago by andar

Yea, I'll think about it some more.

comment:5 Changed 12 years ago by anonymous

  • Milestone 1.1.0 deleted

Milestone 1.1.0 deleted

Note: See TracTickets for help on using tickets.