Renaming folders do not delete olds

[axet]

With already loaded torrent try to rename root folder.

[axet]

same for rc_3

[axet]

same for 1.1.0

[cinderblock]

I'm still seeing this issue in 1.3.0. I have not tried 1.3.1 but as this bug is claiming to be resolved before 1.3.0 was released, I'm guess it was never actually fixed or the change accidentally reverted.

Sorry if this has been fixed in 1.3.1 but I found no evidence towards that in the change logs. (Without the ability to easily test it)

[axet]

it never been fixed.

[Cas]

what is the exact problem. the original post does not have enough details of what is trying to be achieved and the steps needed to reproduce it.

[axet]

i made this video several years ago, and post it as another bug.

​http://www.youtube.com/watch?v=DRo0zRPKdDw

it been successively closed as current one.

[cinderblock]

Cas, The initial description is perfectly concise, while maybe not exhaustive.

Rename a folder in a torrent that has already been added. Open your favorite folder viewer to the download location. The old folder is still there, and empty.

As I regularly rename folders, I had to add a cron job that runs this: find /mnt/downloads -depth -type d -empty -exec rmdir -v {} \;

The video shows the problem pretty well. Although I must disagree with axet's second point that un-started torrents shouldn't create the empty directories. They are quite useful if trying to add a torrent with existing data.

[cinderblock]

I've been looking into the code a little for references to folder renaming and I think I found the bug. First off, the comments in the rename_folder function in core.py say that file and folder renaming are handled by libtorrent as an asynchronous operation so maybe it's something in libtorrent that needs to get fixed.

However, the source indicates a call to torrent.py's rename_folder function. The comments in that function say that a folder rename is really just renaming each file in that path and the code in that function seems to agree with the comment. I'm betting this is where the old folder gets orphaned. Hopefully someone that knows deluge/python better can fix this easily?

[Cas]

Fixed in 1.3-stable: 2354eeca7b