Opened 16 years ago

Last modified 7 years ago

#851 accepted patch

Labels can only be lowercase

Reported by: neggelandia@gmail.com Owned by: Damien Churchill
Priority: trivial Milestone: 2.x
Component: Plugin Version: 1.2.3
Keywords: label lowercase Cc:

Description

Scenario:

  1. Right-click a label and choose Add Label
  1. Enter "UPPERCASE" as name and click OK

What happens:

  • The new label will be named "uppercase"

What should happen:

  • The new label should be named "UPPERCASE"

Attachments (1)

uppercase_labels.diff (918 bytes ) - added by ianmartin 15 years ago.
Allow upercase letters and spaces in labels

Download all attachments as: .zip

Change History (8)

by ianmartin, 15 years ago

Attachment: uppercase_labels.diff added

Allow upercase letters and spaces in labels

comment:1 by ianmartin, 15 years ago

Summary: Labels can only be lowercase[PATCH] Labels can only be lowercase
Type: bugfeature-request

Is there a good reason for only allowing lowercase labels. Trivial patch attached for tip of 1.1.0_RC branch

comment:2 by Calum, 15 years ago

Milestone: 1.3.0

could this be added to master?

comment:3 by Chase, 15 years ago

Hmm, the label name is also the label ID, so having only lower case labels makes this simpler. I know the flexget and the autoadd plugin rely on labels only being lower case, so changes would have to be made elsewhere as well if this were to be implemented. If it was implemented, I think that the label ID should still be lower case, but the display name should be able to be upper case. This would prevent having 2 different labels such as 'tv' and 'TV'.

comment:4 by Damien Churchill, 15 years ago

I don't think that having the labels case insensitive will be a huge issue, I guess just adding a display name to the plugin would suffice?

comment:7 by Calum, 15 years ago

Priority: minortrivial
Summary: [PATCH] Labels can only be lowercaseLabels can only be lowercase
Type: feature-requestpatch
Version: 1.1.51.2.3

comment:8 by Damien Churchill, 15 years ago

Milestone: 1.3.01.4.0
Owner: changed from andar to Damien Churchill
Status: newaccepted

comment:9 by Calum, 7 years ago

Milestone: 2.0.x2.x

Milestone renamed

Note: See TracTickets for help on using tickets.