Opened 15 years ago
Last modified 6 years ago
#851 accepted patch
Labels can only be lowercase
Reported by: | neggelandia@… | Owned by: | damoxc |
---|---|---|---|
Priority: | trivial | Milestone: | 2.x |
Component: | Plugin | Version: | 1.2.3 |
Keywords: | label lowercase | Cc: |
Description
Scenario:
- Right-click a label and choose Add Label
- Enter "UPPERCASE" as name and click OK
What happens:
- The new label will be named "uppercase"
What should happen:
- The new label should be named "UPPERCASE"
Attachments (1)
Change History (8)
Changed 14 years ago by ianmartin
comment:1 Changed 14 years ago by ianmartin
- Summary changed from Labels can only be lowercase to [PATCH] Labels can only be lowercase
- Type changed from bug to feature-request
Is there a good reason for only allowing lowercase labels. Trivial patch attached for tip of 1.1.0_RC branch
comment:3 Changed 13 years ago by gazpachoking
Hmm, the label name is also the label ID, so having only lower case labels makes this simpler. I know the flexget and the autoadd plugin rely on labels only being lower case, so changes would have to be made elsewhere as well if this were to be implemented. If it was implemented, I think that the label ID should still be lower case, but the display name should be able to be upper case. This would prevent having 2 different labels such as 'tv' and 'TV'.
comment:4 Changed 13 years ago by damoxc
I don't think that having the labels case insensitive will be a huge issue, I guess just adding a display name to the plugin would suffice?
comment:7 Changed 13 years ago by Cas
- Priority changed from minor to trivial
- Summary changed from [PATCH] Labels can only be lowercase to Labels can only be lowercase
- Type changed from feature-request to patch
- Version changed from 1.1.5 to 1.2.3
comment:8 Changed 13 years ago by damoxc
- Milestone changed from 1.3.0 to 1.4.0
- Owner changed from andar to damoxc
- Status changed from new to accepted
Allow upercase letters and spaces in labels