Opened 16 years ago
Last modified 7 years ago
#851 accepted patch
Labels can only be lowercase
Reported by: | neggelandia@gmail.com | Owned by: | Damien Churchill |
---|---|---|---|
Priority: | trivial | Milestone: | 2.x |
Component: | Plugin | Version: | 1.2.3 |
Keywords: | label lowercase | Cc: |
Description
Scenario:
- Right-click a label and choose Add Label
- Enter "UPPERCASE" as name and click OK
What happens:
- The new label will be named "uppercase"
What should happen:
- The new label should be named "UPPERCASE"
Attachments (1)
Change History (8)
by , 15 years ago
Attachment: | uppercase_labels.diff added |
---|
comment:1 by , 15 years ago
Summary: | Labels can only be lowercase → [PATCH] Labels can only be lowercase |
---|---|
Type: | bug → feature-request |
Is there a good reason for only allowing lowercase labels. Trivial patch attached for tip of 1.1.0_RC branch
comment:3 by , 15 years ago
Hmm, the label name is also the label ID, so having only lower case labels makes this simpler. I know the flexget and the autoadd plugin rely on labels only being lower case, so changes would have to be made elsewhere as well if this were to be implemented. If it was implemented, I think that the label ID should still be lower case, but the display name should be able to be upper case. This would prevent having 2 different labels such as 'tv' and 'TV'.
comment:4 by , 15 years ago
I don't think that having the labels case insensitive will be a huge issue, I guess just adding a display name to the plugin would suffice?
comment:7 by , 15 years ago
Priority: | minor → trivial |
---|---|
Summary: | [PATCH] Labels can only be lowercase → Labels can only be lowercase |
Type: | feature-request → patch |
Version: | 1.1.5 → 1.2.3 |
comment:8 by , 15 years ago
Milestone: | 1.3.0 → 1.4.0 |
---|---|
Owner: | changed from | to
Status: | new → accepted |
Allow upercase letters and spaces in labels