Opened 9 years ago

Last modified 22 months ago

#856 new bug

Torrents sharing same folder name issue

Reported by: jeff@… Owned by: andar
Priority: minor Milestone: not applicable
Component: libtorrent Version: 1.2.0
Keywords: Cc:

Description

If you are downloading multiple torrents that are downloading into the same folder, and one of the torrent's finishes, the whole folder (and contents) is moved even though the unfinished torrents have files in that folder. The unfinished torrents get an error and stop.

I disovered this bug downloading the slackware install iso's.

Change History (9)

comment:1 Changed 8 years ago by H3g3m0n

  • Version changed from 1.1.5 to 1.2.0_rc3

I have also run into this bug on 2 separate occasions now.

It's not uncommon for multiple torrents to have the same name, you get things like 'ebooks', 'PDFs'.

Still happens with 1.2.0-rc3

I also wounder how Deluge handles multiple torrents with the exact same file names in addition to the directory names, does one get overridden?.

Maybe the best solution is to rename the new directory something like "directory (1)", although it would need to be scanned first to see if it is indeed different (since you don't want to accidently re-add a torrent a few times and end up with file dupes). You would probably only want that happing if there is a filename conflict though since it would be stupid to have "slackwareiso (1)/slack64bit.iso", "slackwareiso (2)/slack32bit.iso", ect... although it might be best to have the behavior set as a user config option since you might not want, say, a huge number of rar files mixing together even if they are different names.

comment:2 Changed 8 years ago by Cas

  • Component changed from other to libtorrent

comment:3 Changed 8 years ago by Cas

  • Version 1.2.0_rc3 deleted

comment:4 Changed 8 years ago by Cas

  • Component changed from libtorrent to core
  • Milestone set to 1.4.0
  • Priority changed from major to minor
  • Summary changed from Move Completed Torrents Bug to Torrents sharing same folder name issue
  • Version set to 1.2.0

I think this is actually a Deluge bug not sure why i marked it lt.

Duplicate tickets: #1129 and #869

comment:5 Changed 8 years ago by Cas

  • Component changed from core to libtorrent
  • Milestone 1.4.0 deleted

johnnyg pointed out it is an lt issue that can be solved by doing a recursive move

comment:6 follow-up: Changed 8 years ago by caramba

They shouldn't share the same folder in the first place, it should be impossible to assign for any new torrent a folder name that is already taken. If that is attempted, deluge should prompt for an alternative name, maybe suggesting a (2) suffix as mentioned.

comment:7 in reply to: ↑ 6 Changed 7 years ago by s0undt3ch

Replying to caramba:

They shouldn't share the same folder in the first place, it should be impossible to assign for any new torrent a folder name that is already taken. If that is attempted, deluge should prompt for an alternative name, maybe suggesting a (2) suffix as mentioned.

Come on, it should be impossible? No it should not be impossible. It should though, only move the files belonging to the torrent that completed.

comment:8 Changed 5 years ago by Cas

  • Milestone set to not applicable

comment:9 Changed 22 months ago by iMikla

This problem still exists in Deluge 1.3.12, as it has just happened to me, and caused a fair amount of frustration figuring out what happened.

The fundamental problem is not LibTorrent?, it is how LibTorrent? is being used. The bug is not that two torrents can use the same folder (though that should be addressed as a separate bug), the bug is that files in that folder are blindly moved along with the target files when a torrent is moved when finished. Only the sub-folders/files that are listed in the torrent file should be moved, not blindly the top-level folder and everything in it.

Note: See TracTickets for help on using tickets.