Changes between Version 1 and Version 2 of Contributing/PullRequests


Ignore:
Timestamp:
05/07/2016 06:21:39 PM (8 years ago)
Author:
Cas
Comment:

small updates to text and layout

Legend:

Unmodified
Added
Removed
Modified
  • Contributing/PullRequests

    v1 v2  
    11If you want to contribute code to Deluge, follow this process: 
    22 
    3 * File a [http://dev.deluge-torrent.org/newticket new ticket]: No patches will be applied to develop unless they are accompanied by an issue. Do a search in the ticket system first to avoid filing a duplicate. 
    4 * Read up on the Deluge [wiki:'Contributing/CodingStyle' Coding Style] 
     3* File a [http://dev.deluge-torrent.org/newticket new ticket]. 
     4  - Patches will not be applied to develop unless they are accompanied by a ticket. 
     5  - Search the ticket system first, to avoid filing a duplicate. 
     6* Ensure code follows the Deluge [wiki:'Contributing/CodingStyle' Coding Style]. 
    57* Write unit tests: See [wiki:'Development/Testing' Unit Testing] for information on how to run the unit tests. 
    6 * Create the Pull Request: 
     8* Write informative [wiki:GitTips#CommitMessages commit messages] 
     9* Create a Pull Request: 
    710  * Fork deluge on [https://github.com/deluge-torrent/deluge github] under your own user account. 
    8   * Clone your repository 
    9   * Create a branch 
    10   * Make your changes: 
    11     * add them, and then commit them to your branch 
    12     * Run the tests until they pass 
    13     * When you feel you are finished, rebase your commits to ensure a simple and informative log 
     11  * Clone your repository. 
     12  * Create a feature branch for your issue. 
     13  * Apply your changes: 
     14    * Add them, and then commit them to your branch. 
     15    * Run the tests until they pass. 
     16    * When you feel you are finished, rebase your commits to ensure a simple and informative commit log. 
    1417  * Create a pull request on github from your forked repository. 
    15     * Verify that the tests run by [https://travis-ci.org/deluge-torrent/deluge Travis-ci] are passing 
     18    * Verify that the tests run by [https://travis-ci.org/deluge-torrent/deluge Travis-ci] are passing.