Opened 7 years ago
Last modified 3 years ago
#3035 reopened bug
Extractor issues with .rar archives of the same name that have a Subs folder
Reported by: | HollowMan | Owned by: | HollowMan |
---|---|---|---|
Priority: | major | Milestone: | Future |
Component: | Plugin | Version: | 1.3.12 |
Keywords: | Cc: |
Description (last modified by )
There's a really weird behavior where torrents that have the a Subs folder and a multipart .rar archive, will have the .rar file overwritten by the one from the Subs folder if it has the same name. Example:
Movie.2017.unrated.1080p.bluray.x264 |_ movie.2017.unrated.1080p.bluray.x264.rar 140MB |_ movie.2017.unrated.1080p.bluray.x264.r01 140MB |_ movie.2017.unrated.1080p.bluray.x264.r02 140MB |_Subs |_ movie.2017.unrated.1080p.bluray.x264.rar 3MB |_ movie.2017.unrated.1080p.bluray.x264.idx 3MB
The 3MB .rar file from the Subs folder will override the 140MB .rar file from the main folder no matter how many Re-Checks you do. It downloads 140MB then it deletes it and replaces it with the 3MB file. This happens all the time.
Tested on Ubuntu 16.04.2 and Debian Jessie with: deluged: 1.3.12 libtorrent: 1.0.7.0
It's utterly annoying as i
Attachments (4)
Change History (19)
by , 7 years ago
Attachment: | broken.png added |
---|
comment:1 by , 7 years ago
Description: | modified (diff) |
---|
comment:2 by , 7 years ago
Are you talking about downloading or extracting? In that png screenshot the rar files have completely different names and in a folder so I don't see how it can be overwriting it.
Have you got any plugins or scripts that could be the actual culprit here?
Can you provide actual evidence of this overwriting/replacing and an example torrent file.
comment:3 by , 7 years ago
The only plugins that i am using are Extractor and Label.
So it downloads all the files, but if there is a file with the same name but in a different folder it will overwrite the one in the root folder with the one from the specific folder.
I do not understand why it's doing this but it happened for me both on Debian 8 and Ubuntu 16.
comment:4 by , 7 years ago
I've added pictures to demonstrate what i am talking about. This is how it looks like after the Extractor plugin has finished it's job. Look at those 2 archive names in the Directory List
get.out.2017.bdrip.x264-sparks.rar Get.Out.2017.BDRip.x264-SPARKS.rar
The one with uppercase is the name of the file from the subs archive.
I just now understood what actually happens. The plugin extracts the sub archive rar in the same folder as the Movie and then it replaces the original file.
Is there any way to avoid this ?
comment:5 by , 7 years ago
Component: | Unknown → Plugin |
---|---|
Milestone: | needs verified → 1.3.15 |
Priority: | critical → major |
Summary: | DelugeD issues with .rar archives of the same name that have a Subs folder! → Extractor issues with .rar archives of the same name that have a Subs folder |
Thanks. I'll need to look into the code to understand what it's doing with the rar files
comment:7 by , 7 years ago
Easiest way to fix this is to extract only the archives found in the torrent root dir and not do it recursively for all the folders in the torrent.
comment:8 by , 6 years ago
From what _ understood by glancing at the code, the destination directory is the same for all extracted files.
Here, a quick fix. It should work.
_ can’t test it because _ don’t know of any such torrents.
comment:10 by , 5 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:12 by , 5 years ago
Hi,
I've stopped using Deluge a few months ago, but i didn't encounter the issue anymore.
comment:13 by , 5 years ago
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
comment:14 by , 5 years ago
Resolution: | Fixed |
---|---|
Status: | closed → reopened |
This was not fixed in the Deluge code so is still an issue
comment:15 by , 3 years ago
Milestone: | 1.3.16 → Future |
---|
An example of file structure