Opened 11 years ago

Last modified 2 years ago

#367 new feature-request

Do not store per-torrent settings that are saved in the resume data

Reported by: andar Owned by: andar
Priority: trivial Milestone: 2.x
Component: Core Version:
Keywords: Cc:

Description

Since libtorrent now stores certain per-torrent settings in the resume data, we no longer need to save this data in the state file.

Change History (8)

comment:1 Changed 10 years ago by anonymous

  • Milestone 1.1.0 deleted

Milestone 1.1.0 deleted

comment:2 Changed 10 years ago by Plisk

  • Milestone set to 1.2.0

comment:3 Changed 10 years ago by andar

  • Milestone changed from 1.2.0 to Future
  • Version 1.1.0_dev deleted

comment:4 Changed 10 years ago by andar

  • Type changed from bug to feature-request

comment:5 Changed 8 years ago by Cas

  • Priority changed from major to trivial

comment:6 Changed 6 years ago by Cas

  • Milestone changed from Future to 1.4.0

These can be removed without any major issue,

torrent_status["last_seen_complete"]
torrent_status["total_uploaded"],
torrent.trackers

These would require updating options from either bdecoded resume_data or handle.status

torrent.options["compact_allocation"],
torrent.options["max_connections"],
torrent.options["max_upload_slots"],
torrent.options["max_upload_speed"],
torrent.options["max_download_speed"],
torrent.options["sequential_download"],
torrent.options["file_priorities"],
torrent.options["auto_managed"],

torrent.time_added could be replaced by lt torrent status added_time

torrent.is_finished could be updated using lt torrent status completed_time but need to verify the reason for original addition [f769429e] and whether still required.


For reference the entire resume data file format for 0.16 (currently lt docs are outdated):

file-format
file-version
info-hash
blocks per piece
pieces
slots
total_uploaded
total_downloaded
active_time
seeding_time
num_seeds
num_downloaders
upload_rate_limit
download_rate_limit
max_connections
max_uploads
seed_mode
file_priority
piece_priority
auto_managed
sequential_download 
paused
trackers 
mapped_files
url-list
httpseeds
merkle tree
peers
unfinished
file sizes
allocation
added_time
announce_to_dht
announce_to_lsd
announce_to_trackers
banned_peers
banned_peers6
completed_time
finished_time
last_download
last_scrape
last_seen_complete
last_upload
libtorrent-version
num_incomplete
peers6
super_seeding
uuid
url
feed
info

comment:7 Changed 6 years ago by Cas

Removed last_seen_complete and total_uploaded: [0da6739f945ce8b]

comment:8 Changed 2 years ago by Cas

  • Milestone changed from 2.0.x to 2.x

Milestone renamed

Note: See TracTickets for help on using tickets.