Connection manager shows wrong info when connected to localhost

[bro]

The problem is that the code distinguishes between localhost and 127.0.0.1 when comparing the hosts.

There are two issues:

1) The gtk-client can connect to localclient@localhost:58846 on startup but an entry in the connection manager with localclient@127.0.0.1:58846 will show as not connected.

2) When adding a new host, it's possible to add localclient@127.0.0.1:58846 if localclient@localhost:58846 is already in the list, and the other way around.

Fix: ​https://github.com/bendikro/deluge/commit/05fb216da9d128f8be24bf9824017b6b80bd28d2

This fix has not been extensively tested, but worked as expected when tested on Ubuntu. The only thing I expect could matter is that in the method update_list, the variable host is changed, and later passed to Client.connect().

[gazpachoking]

Is this really an issue? If you are adding multiple entries for localhost you should know the difference. Even if patch is implemented you could still use the local hostname and exhibit the same problem. Also, you could have an ssh tunnel from 127.0.0.1 to a remote host (although this will cause problems with the path picker.)

[bro]

Yeah, I agree. There are other things to focus on ;-) Pleas close this if you like.

[gazpachoking]

Yeah, to get it perfect we'd have to be looking at hostname/ip, port, and username. Plus with the port forwarding issue I think it's just best to show connected to the daemon the user clicked connect on.