Stop Seeding on Share Ratio Fails for Partially Selected Torrents

[robg]

Bug Report

If you select only one file (or fewer than all the files) from a multiple file torrent to download, and have the "Stop seeding when share ratio reaches" option selected then the torrent will never automatically stop seeding.

Steps to Reproduce

1. In Preferences under "Queue" check the option for "Stop Seeding when share ratio reaches" from the bottom third section labeled "Seeding". Click OK to save preferences
2. Open a torrent file containing multiple files for downloading to Deluge using the GUI.
3. From the Add Torrent panel, select the Files tab.
4. Uncheck one of the files to be downloaded.
5. Add the torrent to the active queue.

Expected result: torrent will stop seeding when ratio reaches the specified value.

Actual result: torrent continues seeding indefinitely

Additional Notes

Single file & multiple file torrents where all the files are downloaded do correctly stop seeding at the specified ratio. This only happens when the torrent has some file not selected for download.

[robg]

#1264 is probably a duplicate of this ticket

[Calum]

I managed to repeat this but am unsure if this is Deluge or libtorrent related as it needs more debugging.

[Calum]

Although not tested for specifically this issue should be fixed by these two commits:

​1f5cfd16e

​2ae936df4